Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 12:18:52PM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Nov 30, 2018 at 09:05:06AM -0500, Neil Horman wrote: > > On Fri, Nov 30, 2018 at 11:33:15AM -0200, Marcelo Ricardo Leitner wrote: > > > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > > > On Fri,

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Xin Long
On Fri, Nov 30, 2018 at 11:27 PM Neil Horman wrote: > > On Fri, Nov 30, 2018 at 11:15:50PM +0900, Xin Long wrote: > > On Fri, Nov 30, 2018 at 10:33 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > > > On Fri, Nov 30, 2018 at

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 11:15:50PM +0900, Xin Long wrote: > On Fri, Nov 30, 2018 at 10:33 PM Marcelo Ricardo Leitner > wrote: > > > > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > > On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > > > > On Fri, Nov 30, 2018 at 5:52

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Marcelo Ricardo Leitner
On Fri, Nov 30, 2018 at 09:05:06AM -0500, Neil Horman wrote: > On Fri, Nov 30, 2018 at 11:33:15AM -0200, Marcelo Ricardo Leitner wrote: > > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > > On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > > > > On Fri, Nov 30, 2018 at

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Xin Long
On Fri, Nov 30, 2018 at 10:33 PM Marcelo Ricardo Leitner wrote: > > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > > > On Fri, Nov 30, 2018 at 5:52 AM Neil Horman wrote: > > > > > > > > On Thu, Nov 29, 2018 at

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 11:33:15AM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > > On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > > > On Fri, Nov 30, 2018 at 5:52 AM Neil Horman wrote: > > > > > > > > On Thu, Nov 29, 2018 at

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Marcelo Ricardo Leitner
On Fri, Nov 30, 2018 at 07:32:36AM -0500, Neil Horman wrote: > On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > > On Fri, Nov 30, 2018 at 5:52 AM Neil Horman wrote: > > > > > > On Thu, Nov 29, 2018 at 02:44:07PM +0800, Xin Long wrote: > > > > Without holding transport to dereference

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 02:04:16PM +0900, Xin Long wrote: > On Fri, Nov 30, 2018 at 5:52 AM Neil Horman wrote: > > > > On Thu, Nov 29, 2018 at 02:44:07PM +0800, Xin Long wrote: > > > Without holding transport to dereference its asoc, a use after > > > free panic can be caused in

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-30 Thread Marcelo Ricardo Leitner
On Thu, Nov 29, 2018 at 02:44:07PM +0800, Xin Long wrote: > Without holding transport to dereference its asoc, a use after > free panic can be caused in sctp_epaddr_lookup_transport. Note > that a sock lock can't protect these transports that belong to > other socks. > > A similar fix as Commit

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-29 Thread Xin Long
On Fri, Nov 30, 2018 at 5:52 AM Neil Horman wrote: > > On Thu, Nov 29, 2018 at 02:44:07PM +0800, Xin Long wrote: > > Without holding transport to dereference its asoc, a use after > > free panic can be caused in sctp_epaddr_lookup_transport. Note > > that a sock lock can't protect these

Re: [PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-29 Thread Neil Horman
On Thu, Nov 29, 2018 at 02:44:07PM +0800, Xin Long wrote: > Without holding transport to dereference its asoc, a use after > free panic can be caused in sctp_epaddr_lookup_transport. Note > that a sock lock can't protect these transports that belong to > other socks. > > A similar fix as Commit

[PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-28 Thread Xin Long
Without holding transport to dereference its asoc, a use after free panic can be caused in sctp_epaddr_lookup_transport. Note that a sock lock can't protect these transports that belong to other socks. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in