Re: [PATCHv2 net-next 1/4] sctp: define subscribe in sctp_sock as __u16

2018-11-14 Thread Xin Long
On Wed, Nov 14, 2018 at 2:16 AM Neil Horman wrote: > > On Tue, Nov 13, 2018 at 02:24:53PM +0800, Xin Long wrote: > > > > /* Default Peer Address Parameters. These defaults can > >* be modified via SCTP_PEER_ADDR_PARAMS > > @@ -5267,14 +5274,24 @@ static int

Re: [PATCHv2 net-next 1/4] sctp: define subscribe in sctp_sock as __u16

2018-11-13 Thread Neil Horman
On Tue, Nov 13, 2018 at 02:24:53PM +0800, Xin Long wrote: > > /* Default Peer Address Parameters. These defaults can >* be modified via SCTP_PEER_ADDR_PARAMS > @@ -5267,14 +5274,24 @@ static int sctp_getsockopt_disable_fragments(struct > sock *sk, int len, > static int

[PATCHv2 net-next 1/4] sctp: define subscribe in sctp_sock as __u16

2018-11-12 Thread Xin Long
The member subscribe in sctp_sock is used to indicate to which of the events it is subscribed, more like a group of flags. So it's better to be defined as __u16 (2 bytpes), instead of struct sctp_event_subscribe (13 bytes). Note that sctp_event_subscribe is an UAPI struct, used on sockopt calls,