Re: [PATCN v2 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

2016-12-04 Thread Eric Dumazet
On Sat, 2016-12-03 at 23:18 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > 1) Old code was hard to maintain, due to complex lock chains. >(We probably will be able to remove some kfree_rcu() in callers) > > 2) Using a single timer to update all estimators does not

Re: [PATCN v2 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

2016-12-04 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net_sched-gen_estimator-complete-rewrite-of-rate-estimators/20161204-182009 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/sock.h:467: warning:

[PATCN v2 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

2016-12-03 Thread Eric Dumazet
From: Eric Dumazet 1) Old code was hard to maintain, due to complex lock chains. (We probably will be able to remove some kfree_rcu() in callers) 2) Using a single timer to update all estimators does not scale. 3) Code was buggy on 32bit kernel (WRITE_ONCE() on 64bit