Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-14 Thread David Miller
From: Yuval Shaia Date: Tue, 13 Jun 2017 23:40:41 +0300 > On Tue, Jun 13, 2017 at 01:36:24PM -0700, Cong Wang wrote: >> Laura reported a sleep-in-atomic kernel warning inside > > Since you added a Reported-by tag below i don't see a reason to > specifically mention it in

Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-14 Thread David Miller
From: Cong Wang Date: Tue, 13 Jun 2017 13:36:24 -0700 > Laura reported a sleep-in-atomic kernel warning inside > tcf_act_police_init() which calls gen_replace_estimator() with > spinlock protection. > > It is not necessary in this case, we already have RTNL lock here >

Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-14 Thread Jamal Hadi Salim
On 17-06-13 04:36 PM, Cong Wang wrote: Laura reported a sleep-in-atomic kernel warning inside tcf_act_police_init() which calls gen_replace_estimator() with spinlock protection. It is not necessary in this case, we already have RTNL lock here so it is enough to protect concurrent writers. For

Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-13 Thread Cong Wang
On Tue, Jun 13, 2017 at 1:40 PM, Yuval Shaia wrote: > On Tue, Jun 13, 2017 at 01:36:24PM -0700, Cong Wang wrote: >> Laura reported a sleep-in-atomic kernel warning inside > > Since you added a Reported-by tag below i don't see a reason to > specifically mention it in

Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-13 Thread Yuval Shaia
On Tue, Jun 13, 2017 at 01:36:24PM -0700, Cong Wang wrote: > Laura reported a sleep-in-atomic kernel warning inside Since you added a Reported-by tag below i don't see a reason to specifically mention it in commit log message. > tcf_act_police_init() which calls gen_replace_estimator() with >

[Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

2017-06-13 Thread Cong Wang
Laura reported a sleep-in-atomic kernel warning inside tcf_act_police_init() which calls gen_replace_estimator() with spinlock protection. It is not necessary in this case, we already have RTNL lock here so it is enough to protect concurrent writers. For the reader, i.e. tcf_act_police(), it