Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-30 Thread Vlad Buslov
On Fri 28 Sep 2018 at 17:03, Cong Wang wrote: > On Fri, Sep 28, 2018 at 4:36 AM Vlad Buslov wrote: >> >> On Thu 27 Sep 2018 at 20:42, Cong Wang wrote: >> > It is clearly a copy-n-paste. >> > >> > Signed-off-by: Cong Wang >> > --- >> > net/sched/cls_api.c | 2 +- >> > 1 file changed, 1

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-28 Thread Cong Wang
On Thu, Sep 27, 2018 at 1:42 PM Cong Wang wrote: > > It is clearly a copy-n-paste. > > Signed-off-by: Cong Wang I regret again for wasting my time, so: NAcked-by: Cong Wang I really don't care, do you?

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-28 Thread Cong Wang
On Fri, Sep 28, 2018 at 4:36 AM Vlad Buslov wrote: > > On Thu 27 Sep 2018 at 20:42, Cong Wang wrote: > > It is clearly a copy-n-paste. > > > > Signed-off-by: Cong Wang > > --- > > net/sched/cls_api.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-28 Thread Vlad Buslov
On Thu 27 Sep 2018 at 20:42, Cong Wang wrote: > It is clearly a copy-n-paste. > > Signed-off-by: Cong Wang > --- > net/sched/cls_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 3de47e99b788..8dd7f8af6d54 100644 >

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-27 Thread David Ahern
On 9/27/18 3:36 PM, Cong Wang wrote: > On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: >> >> >> >> On 09/27/2018 01:42 PM, Cong Wang wrote: >>> It is clearly a copy-n-paste. >>> >>> Signed-off-by: Cong Wang >>> --- >>> net/sched/cls_api.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-27 Thread Eric Dumazet
On 09/27/2018 02:36 PM, Cong Wang wrote: > I don't understand what you mean by changing ip command, you must > mean tc command, but still, I have no idea about how restarting failed > syscall could be related to my patch and why we need to restart anything > here. If the refcnt goes to 0, it

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-27 Thread Cong Wang
On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: > > > > On 09/27/2018 01:42 PM, Cong Wang wrote: > > It is clearly a copy-n-paste. > > > > Signed-off-by: Cong Wang > > --- > > net/sched/cls_api.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-27 Thread Eric Dumazet
On 09/27/2018 01:42 PM, Cong Wang wrote: > It is clearly a copy-n-paste. > > Signed-off-by: Cong Wang > --- > net/sched/cls_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 3de47e99b788..8dd7f8af6d54 100644 >

[Patch net-next] net_sched: fix an extack message in tcf_block_find()

2018-09-27 Thread Cong Wang
It is clearly a copy-n-paste. Signed-off-by: Cong Wang --- net/sched/cls_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 3de47e99b788..8dd7f8af6d54 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -655,7