Re: [RESEND PATCH net 06/10] net: ethernet: mediatek: fix the loss

2016-08-28 Thread Sean Wang
Date: Fri, 26 Aug 2016 16:17:59 +0200, Andrew Lunn wrote: >> Hi Andrew, >> >> Here pinctrl is used to setup what function the group of the pins is >> for. > >Agreed. > >> The group of the pins could be configured for the function provided >> by the SoC, such as general purpose I/O or specific

Re: [RESEND PATCH net 06/10] net: ethernet: mediatek: fix the loss

2016-08-26 Thread Andrew Lunn
> Hi Andrew, > > Here pinctrl is used to setup what function the group of the pins is > for. Agreed. > The group of the pins could be configured for the function provided > by the SoC, such as general purpose I/O or specific function such as > ethernet depending on what products or boards you

Re: [RESEND PATCH net 06/10] net: ethernet: mediatek: fix the loss

2016-08-25 Thread Sean Wang
On Thu, 25 Aug 2016 15:30:34 +0200, Andrew Lunn wrote: >On Thu, Aug 25, 2016 at 06:44:57PM +0800, Sean Wang wrote: >> ommited the setting about pin-mux which results in incorrect signals >> being routed on GMAC2. > >Hi Sean > >Please could you explain this some more. I don't know too much about

Re: [RESEND PATCH net 06/10] net: ethernet: mediatek: fix the loss of pin-mux setting for GMAC2

2016-08-25 Thread Andrew Lunn
On Thu, Aug 25, 2016 at 06:44:57PM +0800, Sean Wang wrote: > ommited the setting about pin-mux which results in incorrect signals > being routed on GMAC2. Hi Sean Please could you explain this some more. I don't know too much about pinctrl, but i've never seen a driver have to do anything with

[RESEND PATCH net 06/10] net: ethernet: mediatek: fix the loss of pin-mux setting for GMAC2

2016-08-25 Thread Sean Wang
ommited the setting about pin-mux which results in incorrect signals being routed on GMAC2. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 14 ++ drivers/net/ethernet/mediatek/mtk_eth_soc.h | 3 +++ 2 files changed, 17