Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-13 Thread Subrata Modak
Do you think we can improve upon our own LTP-KDUMP test cases housed here: http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kdump/, because of your changes below: --Subrata On Wed, 2007-12-12 at 17:53 +0100, Thomas Klein wrote: This patch adds kdump support using the new PPC crash shutdown

[RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Thomas Klein
This patch adds kdump support using the new PPC crash shutdown hook to the ehea driver. The driver now keeps a list of firmware handles which have to be freed in case of a crash. The crash handler does the minimum required: it frees the firmware resource handles plus broadcast/multicast

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Dave Jones
On Wed, Dec 12, 2007 at 05:53:43PM +0100, Thomas Klein wrote: +static void ehea_update_adapter_handles(struct ehea_adapter *adapter) +{ +int i, k; +int j = 0; + +memset(adapter-res_handles, sizeof(adapter-res_handles), 0); arguments wrong way around. Dave --

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
On Wed, 2007-12-12 at 12:04 -0500, Dave Jones wrote: On Wed, Dec 12, 2007 at 05:53:43PM +0100, Thomas Klein wrote: +static void ehea_update_adapter_handles(struct ehea_adapter *adapter) +{ + int i, k; + int j = 0; + + memset(adapter-res_handles, sizeof(adapter-res_handles),

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
On Wed, 2007-12-12 at 17:53 +0100, Thomas Klein wrote: This patch adds kdump support using the new PPC crash shutdown hook to the ehea driver. The driver now keeps a list of firmware handles which have to be freed in case of a crash. The crash handler does the minimum required: it frees the