Re: [RFC 02/12] net: cls_bpf: add hardware offload

2016-06-02 Thread Jakub Kicinski
On Thu, 2 Jun 2016 09:17:15 +0200, Jiri Pirko wrote: > >+static void cls_bpf_stop_offload(struct tcf_proto *tp, > >+ struct cls_bpf_prog *prog) > >+{ > >+struct net_device *dev = tp->q->dev_queue->dev; > >+ > >+if (!prog->offloaded) > >+return; > >+

Re: [RFC 02/12] net: cls_bpf: add hardware offload

2016-06-02 Thread Jiri Pirko
Wed, Jun 01, 2016 at 06:50:04PM CEST, jakub.kicin...@netronome.com wrote: >This patch adds hardware offload capability to cls_bpf classifier, >similar to what have been done with U32 and flower. > >Signed-off-by: Jakub Kicinski >Reviewed-by: Dinan Gunawardena >Reviewed-by: Simon Horman >--- > in

Re: [RFC 02/12] net: cls_bpf: add hardware offload

2016-06-01 Thread Jakub Kicinski
On Wed, 1 Jun 2016 10:13:48 -0700, John Fastabend wrote: > > +static void cls_bpf_stop_offload(struct tcf_proto *tp, > > +struct cls_bpf_prog *prog) > > +{ > > + struct net_device *dev = tp->q->dev_queue->dev; > > + > > + if (!prog->offloaded) > > + return;

Re: [RFC 02/12] net: cls_bpf: add hardware offload

2016-06-01 Thread Daniel Borkmann
On 06/01/2016 06:50 PM, Jakub Kicinski wrote: This patch adds hardware offload capability to cls_bpf classifier, similar to what have been done with U32 and flower. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman Nice! This is truly awesome to see this

Re: [RFC 02/12] net: cls_bpf: add hardware offload

2016-06-01 Thread John Fastabend
On 16-06-01 09:50 AM, Jakub Kicinski wrote: > This patch adds hardware offload capability to cls_bpf classifier, > similar to what have been done with U32 and flower. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dinan Gunawardena > Reviewed-by: Simon Horman > --- Nice! [...] > +static v

[RFC 02/12] net: cls_bpf: add hardware offload

2016-06-01 Thread Jakub Kicinski
This patch adds hardware offload capability to cls_bpf classifier, similar to what have been done with U32 and flower. Signed-off-by: Jakub Kicinski Reviewed-by: Dinan Gunawardena Reviewed-by: Simon Horman --- include/linux/netdevice.h | 2 ++ include/net/pkt_cls.h | 14 ++ net/sc