Re: [RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-12 Thread Evgeniy Polyakov
Hi, Jan-Bernd. I have couple of comments over implementation besides one you saw previous time. On Wed, Jul 11, 2007 at 04:21:34PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: +static int lro_tcp_ip_check(struct sk_buff *skb, struct iphdr *iph, + struct tcphdr

Re: [RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-12 Thread Jan-Bernd Themann
Hi Evgeniy On Thursday 12 July 2007 10:01, Evgeniy Polyakov wrote: + + if (tcph-cwr || tcph-ece || tcph-urg || !tcph-ack || tcph-psh + || tcph-rst || tcph-syn || tcph-fin) + return -1; I think you do not want to break lro frame because of push flag - it is pretty