Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: > Hi Guenter, Andrew, > > On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: > On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> >Disable the mirroring p

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Vivien Didelot
Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> >Disable the mirroring policy in the monitor control register, since this >> >feature is not needed.

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Andrew Lunn
On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >Disable the mirroring policy in the monitor control register, since this > >feature is not needed. > > > >Signed-off-by: Vivien Didelot > > Should this be a separate patch, unrelated

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy in the monitor control register, since this feature is not needed. Signed-off-by: Vivien Didelot Should this be a separate patch, unrelated to the patch set ? If I understand correctly, this effectively disables IGMP/

[RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-01 Thread Vivien Didelot
Disable the mirroring policy in the monitor control register, since this feature is not needed. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6352.c | 10 +++--- drivers/net/dsa/mv88e6xxx.h | 1 + 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/mv88e6