Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-04 Thread Alexei Starovoitov
On Mon, Apr 04, 2016 at 09:48:46AM +0200, Jesper Dangaard Brouer wrote: > On Sat, 2 Apr 2016 22:41:04 -0700 > Brenden Blanco wrote: > > > On Sat, Apr 02, 2016 at 12:47:16PM -0400, Tom Herbert wrote: > > > > > Very nice! Do you think this hook will be sufficient to implement

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-04 Thread Jesper Dangaard Brouer
On Sat, 2 Apr 2016 22:41:04 -0700 Brenden Blanco wrote: > On Sat, Apr 02, 2016 at 12:47:16PM -0400, Tom Herbert wrote: > > > Very nice! Do you think this hook will be sufficient to implement a > > fast forward patch also? (DMA experts please verify and correct me!) One of

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-04 Thread Johannes Berg
On Sun, 2016-04-03 at 11:28 +0900, Lorenzo Colitti wrote: > That said, getting BPF to the driver is part of the picture. On the > chipsets we're targeting for APF, we're only seeing 2k-4k of memory > (that's 256-512 BPF instructions) available for filtering code, which > means that BPF might be

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-02 Thread Brenden Blanco
On Sat, Apr 02, 2016 at 12:47:16PM -0400, Tom Herbert wrote: > Very nice! Do you think this hook will be sufficient to implement a > fast forward patch also? That is the goal, but more work needs to be done of course. It won't be possible with just a single pseudo skb, the driver will need a fast

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-02 Thread Lorenzo Colitti
On Sun, Apr 3, 2016 at 7:57 AM, Tom Herbert wrote: > I am curious though, how do you think this would specifically help > Android with power? Seems like the receiver still needs to be powered > to receive packets to filter them anyway... The receiver is powered up, but its

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-02 Thread Tom Herbert
On Sat, Apr 2, 2016 at 2:41 PM, Johannes Berg wrote: > On Fri, 2016-04-01 at 18:21 -0700, Brenden Blanco wrote: >> This patch set introduces new infrastructure for programmatically >> processing packets in the earliest stages of rx, as part of an effort >> others are

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-02 Thread Johannes Berg
On Fri, 2016-04-01 at 18:21 -0700, Brenden Blanco wrote: > This patch set introduces new infrastructure for programmatically > processing packets in the earliest stages of rx, as part of an effort > others are calling Express Data Path (XDP) [1]. Start this effort by > introducing a new bpf

Re: [RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-02 Thread Tom Herbert
On Fri, Apr 1, 2016 at 9:21 PM, Brenden Blanco wrote: > This patch set introduces new infrastructure for programmatically > processing packets in the earliest stages of rx, as part of an effort > others are calling Express Data Path (XDP) [1]. Start this effort by >

[RFC PATCH 0/5] Add driver bpf hook for early packet drop

2016-04-01 Thread Brenden Blanco
This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling Express Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early packet filtering, before even an skb has been