subject:"\[RFC PATCH 12\/16\] dsa\: Make mdio bus optional"

Re: [RFC PATCH 12/16] dsa: Make mdio bus optional

2016-05-27 Thread Vivien Didelot

Hi Andrew, Andrew Lunn writes: > On Fri, May 27, 2016 at 10:55:45AM -0400, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> > - mdiobus_unregister(ds->slave_mii_bus); >> > + if (ds->slave_mii_bus && ds->drv->phy_read) >> > +

Re: [RFC PATCH 12/16] dsa: Make mdio bus optional

2016-05-27 Thread Andrew Lunn

On Fri, May 27, 2016 at 10:55:45AM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > - mdiobus_unregister(ds->slave_mii_bus); > > + if (ds->slave_mii_bus && ds->drv->phy_read) > > + mdiobus_unregister(ds->slave_mii_bus); > > So if a driver

Re: [RFC PATCH 12/16] dsa: Make mdio bus optional

2016-05-27 Thread Vivien Didelot

Hi Andrew, Andrew Lunn writes: > - mdiobus_unregister(ds->slave_mii_bus); > + if (ds->slave_mii_bus && ds->drv->phy_read) > + mdiobus_unregister(ds->slave_mii_bus); So if a driver registered the slave MII bus itself, it may have unregistered it itself as

[RFC PATCH 12/16] dsa: Make mdio bus optional

2016-05-26 Thread Andrew Lunn

The switch may want to instantiate its own MDIO bus. Only do it centrally if the switch has not already created one, and the read op is implemented. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-)