Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Stephan Mueller
Am Dienstag, 24. November 2015, 12:54:07 schrieb Phil Sutter: Hi Phil, > >There "still" are dedicated crypto engines out there which need a driver >to be accessed, so using them from userspace is not as simple as with >padlock or AESNI. This was the reasoning behind the various cryptodev >implemen

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Stephan Mueller
Am Dienstag, 24. November 2015, 12:20:00 schrieb Hannes Frederic Sowa: Hi Hannes, > >You could also keep the secret in a master process and talk to that via >ipc. I could not agree more. Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Phil Sutter
Hi, On Tue, Nov 24, 2015 at 12:20:00PM +0100, Hannes Frederic Sowa wrote: > Stephan Mueller writes: > > > Am Dienstag, 24. November 2015, 18:34:55 schrieb Herbert Xu: > > > > Hi Herbert, > > > >>On Mon, Nov 23, 2015 at 09:43:02AM -0800, Dave Watson wrote: > >>> Userspace crypto interface for TLS

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Sowmini Varadhan
On (11/24/15 12:20), Hannes Frederic Sowa wrote: > There are some crypto acclerators out there so that putting tls into the > kernel would give a net benefit, because otherwise user space has to > copy data into the kernel for device access and back to user space until > it can finally be send out

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Hannes Frederic Sowa
Hello, Stephan Mueller writes: > Am Dienstag, 24. November 2015, 18:34:55 schrieb Herbert Xu: > > Hi Herbert, > >>On Mon, Nov 23, 2015 at 09:43:02AM -0800, Dave Watson wrote: >>> Userspace crypto interface for TLS. Currently supports gcm(aes) 128bit >>> only, however the interface is the same a

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Stephan Mueller
Am Dienstag, 24. November 2015, 18:34:55 schrieb Herbert Xu: Hi Herbert, >On Mon, Nov 23, 2015 at 09:43:02AM -0800, Dave Watson wrote: >> Userspace crypto interface for TLS. Currently supports gcm(aes) 128bit >> only, however the interface is the same as the rest of the SOCK_ALG >> interface, so

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-24 Thread Herbert Xu
On Mon, Nov 23, 2015 at 09:43:02AM -0800, Dave Watson wrote: > Userspace crypto interface for TLS. Currently supports gcm(aes) 128bit only, > however the interface is the same as the rest of the SOCK_ALG interface, so it > should be possible to add more without any user interface changes. SOCK_AL

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-23 Thread Sowmini Varadhan
On (11/23/15 13:43), Dave Watson wrote: > > For kcm, opfd is the fd you would pass along in kcm_attach. > For rds, it looks like you'd want to use opfd as the sock instead of > the new one created by sock_create_kern in rds_tcp_conn_connect. I see. It's something to consider, and it would certai

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-23 Thread Dave Watson
On 11/23/15 02:27 PM, Sowmini Varadhan wrote: > On (11/23/15 09:43), Dave Watson wrote: > > Currently gcm(aes) represents ~80% of our SSL connections. > > > > Userspace interface: > > > > 1) A transform and op socket are created using the userspace crypto > > interface > > 2) Setsockopt ALG_SET_AU

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-23 Thread Sowmini Varadhan
On (11/23/15 09:43), Dave Watson wrote: > Currently gcm(aes) represents ~80% of our SSL connections. > > Userspace interface: > > 1) A transform and op socket are created using the userspace crypto interface > 2) Setsockopt ALG_SET_AUTHSIZE is called > 3) Setsockopt ALG_SET_KEY is called twice, s

[RFC PATCH 2/2] Crypto kernel tls socket

2015-11-23 Thread Dave Watson
Userspace crypto interface for TLS. Currently supports gcm(aes) 128bit only, however the interface is the same as the rest of the SOCK_ALG interface, so it should be possible to add more without any user interface changes. Currently gcm(aes) represents ~80% of our SSL connections. Userspace inte