Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-29 Thread Alexander Duyck
On Fri, Apr 29, 2016 at 12:27 PM, Saeed Mahameed wrote: > On Fri, Apr 29, 2016 at 4:59 AM, Alexander Duyck > wrote: >> On Thu, Apr 28, 2016 at 6:18 PM, Matthew Finlay wrote: >>> >>> >>> >>> >>> > > The mlx5

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-29 Thread Saeed Mahameed
On Fri, Apr 29, 2016 at 4:59 AM, Alexander Duyck wrote: > On Thu, Apr 28, 2016 at 6:18 PM, Matthew Finlay wrote: >> >> >> >> >> The mlx5 hardware requires the outer UDP checksum is not set when offloading encapsulated packets. >>>

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-28 Thread Alexander Duyck
On Thu, Apr 28, 2016 at 6:18 PM, Matthew Finlay wrote: > > > > > >>> >>> The mlx5 hardware requires the outer UDP checksum is not set when >>> offloading encapsulated packets. >> >>The Intel documentation said the same thing. That was due to the fact >>that the hardware

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-28 Thread Matthew Finlay
>> >> The mlx5 hardware requires the outer UDP checksum is not set when offloading >> encapsulated packets. > >The Intel documentation said the same thing. That was due to the fact >that the hardware didn't computer the outer UDP header checksum. I >suspect the Mellanox hardware has the

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-28 Thread Matthew Finlay
On 4/20/16, 11:06 AM, "Alexander Duyck" wrote: >On Wed, Apr 20, 2016 at 10:40 AM, Saeed Mahameed > wrote: >> On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck >> wrote: >>> This patch assumes that the mlx5 hardware

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-28 Thread Alexander Duyck
On Thu, Apr 28, 2016 at 2:43 PM, Matthew Finlay wrote: > > > > > > On 4/20/16, 11:06 AM, "Alexander Duyck" wrote: > >>On Wed, Apr 20, 2016 at 10:40 AM, Saeed Mahameed >> wrote: >>> On Tue, Apr 19, 2016 at 10:06 PM,

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Alexander Duyck
On Wed, Apr 20, 2016 at 10:40 AM, Saeed Mahameed wrote: > On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: >> This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 >> header fields for length and checksum as well as the

Re: [RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 10:06 PM, Alexander Duyck wrote: > This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. > > I have no means of testing this as

[RFC PATCH 2/5] mlx5: Add support for UDP tunnel segmentation with outer checksum offload

2016-04-19 Thread Alexander Duyck
This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP headers. I have no means of testing this as I do not have any mlx5 hardware but thought I would submit it as an RFC to see if anyone