Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
On Sun, 13 Jan 2008, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 14 Jan 2008 09:43:08 +0200 (EET) I'd prefer sending them as iso-8859-1 compliant (and I guess you are able to test your fix-to-utf-8 machinery with it as well :-)), as it would also make my mails compatible with other people's git apply tools you're not using (otherwise I'd probably forget to change it occassionally when interacting with others than you). For now either way is fine with me. If the situation changes I'll let you know. Ok, I'll remain in iso-8859-1, it's something that is known to work from my end. Thanks anyway for fixing it, wasn't any big deal for me at any point of time but people started asking me privately to correct it which I of course couldn't... :-) I'm surprised git-send-email can't get it purely utf8 correctly. The problem is that my system is ISO natively, so git-send-email might encode a ISO native .patch file's content while sending, which in this case was intentionally already utf-8. It might surprise you but it wasn't a long time ago when git-send-email wouldn't care less e.g. about header encoding and I got rejects from netdev due to my name which wasn't encoded properly, I've 1.5.0.6 currently and it seemed still fail to encode Cc addresses it adds from signed-offs unless I explicitly ask for it to not do that (I explicitly ask for especific, encoded, from header anyway because it was broken at some point of time and my sending template is copy-paste originating from that time). There was some recent fixes in the git's logs regarding that encoding, so I intend to check if a later g-s-e is more able and if it isn't I'll report it to git folks. I wonder if there is some issue with how it gets your name string for the commit author etc. I've had it working well since the encoding header got relatively recently added (wasn't available at early dawn of git era), before that it was just a mess locally. Funny enough, you were able to magically mangle my emails to utf-8'ed commits nicely back then so I got a fixed commit back after an RTT :-). I wonder if getting it into your global GIT config file in proper UTF8 encoding would fix things. Put something like this into ~/.gitconfig [user] name = Ilpo Järvinen email = [EMAIL PROTECTED] I have this. In addition I have this (required to make my local system consistent): [i18n] commitencoding = ISO-8859-1 The problem was just that the API (or better, ABI) between us wasn't properly working :-)). While Herbert was working as the replacement-Dave in November, correct commit entries were created, so git has been working fine (I guess he used git applying tools instead of handmade scripts and they handle email correclt based on it's encoding). I tried logOutputEncoding = utf-8 in the last patch sets I sent (now could again remove it) but git-send-email problem appeared with it because the system is ISO natively. The GIT maintainer is Finnish which makes this situation even more perplexing to me, you might want to discuss it with him :-) Junio? Never heard that a Finnish name... ;-) Perhaps git-send-email wasn't written by that Finnish guy... :-) ...Besides, that Finnish git aintainer doesn't have any funny characters in his name... ;-) Thanks anyway for the tips all, I think we have it now working and I can return to inlines and rexmit_skb_hint things other TCP stuff rather than this hinderance. I've some interesting results from net header inlines checks I ran overnight :-). -- i.
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 14 Jan 2008 10:33:34 +0200 (EET) Thanks anyway for the tips all, I think we have it now working and I can return to inlines and rexmit_skb_hint things other TCP stuff rather than this hinderance. I've some interesting results from net header inlines checks I ran overnight :-). Great, I look forward to seeing it :) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 14 Jan 2008 09:43:08 +0200 (EET) So which test case you prefer? :-) Is iso-8859-1 from+content ok? Or should I keep trying to live with mixed utf-8 which I didn't got even fully working last time because git-send-email is probably either too dumb or too intelligent (I'm not even sure which), but you were able correct it by your tools so the flawed signed-off never entered to the git logs as incorrectly formatted :-). I'd prefer sending them as iso-8859-1 compliant (and I guess you are able to test your fix-to-utf-8 machinery with it as well :-)), as it would also make my mails compatible with other people's git apply tools you're not using (otherwise I'd probably forget to change it occassionally when interacting with others than you). For now either way is fine with me. If the situation changes I'll let you know. I'm surprised git-send-email can't get it purely utf8 correctly. I wonder if there is some issue with how it gets your name string for the commit author etc. I wonder if getting it into your global GIT config file in proper UTF8 encoding would fix things. Put something like this into ~/.gitconfig [user] name = Ilpo Järvinen email = [EMAIL PROTECTED] The GIT maintainer is Finnish which makes this situation even more perplexing to me, you might want to discuss it with him :-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
On Sat, 12 Jan 2008, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 12 Jan 2008 14:59:50 +0200 (EET) ...Maybe I just fall-back to changing my last name, it's the only full-proof solution... ;-) Don't do this! Otherwise I won't have a frequent test case to make sure my patch applying scripts are working properly. :- So which test case you prefer? :-) Is iso-8859-1 from+content ok? Or should I keep trying to live with mixed utf-8 which I didn't got even fully working last time because git-send-email is probably either too dumb or too intelligent (I'm not even sure which), but you were able correct it by your tools so the flawed signed-off never entered to the git logs as incorrectly formatted :-). I'd prefer sending them as iso-8859-1 compliant (and I guess you are able to test your fix-to-utf-8 machinery with it as well :-)), as it would also make my mails compatible with other people's git apply tools you're not using (otherwise I'd probably forget to change it occassionally when interacting with others than you). -- i.
[RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
net/core/pktgen.c:
pktgen_stop_device | -50
pktgen_run | -105
pktgen_if_show | -37
pktgen_thread_worker | -702
4 functions changed, 894 bytes removed, diff: -894
net/core/pktgen.c:
getCurUs | +36
1 function changed, 36 bytes added, diff: +36
net/core/pktgen.o:
5 functions changed, 36 bytes added, 894 bytes removed, diff: -858
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/core/pktgen.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ebfb126..d18fdb1 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -405,7 +405,7 @@ static inline __u64 tv_to_us(const struct timeval *tv)
return us;
}
-static inline __u64 getCurUs(void)
+static __u64 getCurUs(void)
{
struct timeval tv;
do_gettimeofday(tv);
--
1.5.0.6
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 12 Jan 2008 11:34:29 +0200 net/core/pktgen.c: pktgen_stop_device | -50 pktgen_run | -105 pktgen_if_show | -37 pktgen_thread_worker | -702 4 functions changed, 894 bytes removed, diff: -894 net/core/pktgen.c: getCurUs | +36 1 function changed, 36 bytes added, diff: +36 net/core/pktgen.o: 5 functions changed, 36 bytes added, 894 bytes removed, diff: -858 Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] I think this is the right thing to do, applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
Hi Ilpo:
On Sat, Jan 12, 2008 at 09:40:17AM +, Ilpo Järvinen wrote:
Your emails are now using UTF-8 encoding but it's still declaring
ISO-8859-1 as the charset. So you probably want to fix that up or
your name may show up as Jävinen on the reader's screen.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
On Sat, 12 Jan 2008, Herbert Xu wrote: On Sat, Jan 12, 2008 at 09:40:17AM +, Ilpo Järvinen wrote: Your emails are now using UTF-8 encoding but it's still declaring ISO-8859-1 as the charset. Thanks for trying to help but my situation is such that I think it got also you confused (this kind of mixed encoding is beoynd my skills really)... :-) Besides, I wouldn't mind of having incorrect characters in my name, I'm just used to that but somebody else wasn't that happy about it. Here's one example... From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= [EMAIL PROTECTED] ... Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Something still needed besides these to declare email utf-8? So you probably want to fix that up or your name may show up as Jävinen on the reader's screen. Did you actually see this? I'd expect to see that as well but no, From is correctly decoded by my ISO-8859-1'ish MUA, aha, seems that I still have something to do to deal with the Signed-off line. ...Maybe I just fall-back to changing my last name, it's the only full-proof solution... ;-) -- i.
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
On Sat, Jan 12, 2008 at 02:59:50PM +0200, Ilpo Järvinen wrote:
Here's one example...
From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= [EMAIL PROTECTED]
...
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Something still needed besides these to declare email utf-8?
If that's what it said then it'd be perfect. However, quoting from this
very email that I'm replying to:
Content-Type: text/plain; charset=iso-8859-1
So you probably want to fix that up or your name may show up as Jävinen
on the reader's screen.
Did you actually see this? I'd expect to see that as well but no, From is
correctly decoded by my ISO-8859-1'ish MUA, aha, seems that I still have
something to do to deal with the Signed-off line.
Yeah I did see that. Otherwise I wouldn't have noticed :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 12 Jan 2008 23:17:40 +1100 Your emails are now using UTF-8 encoding but it's still declaring ISO-8859-1 as the charset. So you probably want to fix that up or your name may show up as Jävinen on the reader's screen. Yes, for people using the GIT email patch applying tools, it might do that. However I believe there are options to git-am and friends to force it to put things into UTF-8. I ran into some problems with encoding because I apply stuff by hand using scripts I wrote. But those problem won't happen any more for me. I'm now saving the commit message and patch into files explicitly in emacs, and verifying the coding (with C-h C RET) and if it's wrong I fix it before saving with C-x RET f mule-utf-8 Then I feed those into my patch applying scripts. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 12 Jan 2008 14:59:50 +0200 (EET) ...Maybe I just fall-back to changing my last name, it's the only full-proof solution... ;-) Don't do this! Otherwise I won't have a frequent test case to make sure my patch applying scripts are working properly. :- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
