SACK scoreboard (Was: Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one)

2007-12-15 Thread Ilpo Järvinen
On Tue, 11 Dec 2007, David Miller wrote: > Interesting approach, but I think there is limited value to this > (arguably) complex form. > > The core issue is that the data and the SACK state are maintained in > the same datastructure. The complexity in all the state management > and fixups in your

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 15:35:49 -0800 "Lachlan Andrew" <[EMAIL PROTECTED]> wrote: > Greetings Dave, > > On 12/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > > From: "Lachlan Andrew" <[EMAIL PROTECTED]> > > Date: Tue, 11 Dec 2007 16:14:36 -0800 > > > > > This thread started because TCP processing

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread David Miller
From: "Lachlan Andrew" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 15:35:49 -0800 > I thought that a TSC read was fairly cheap. The TSC is cheap, but on the vast majority of systems it isn't usable as a stable time source, and we have to read the ACPI timer instead. -- To unsubscribe from this lis

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread Lachlan Andrew
Greetings Dave, On 12/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > From: "Lachlan Andrew" <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 16:14:36 -0800 > > > This thread started because TCP processing interferes with RTT > > estimation. This problem would be eliminated if time-stamping were >

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread David Miller
From: "Lachlan Andrew" <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 16:14:36 -0800 > This thread started because TCP processing interferes with RTT > estimation. This problem would be eliminated if time-stamping were > done as soon as the packet comes off the NIC. We don't do that because such tim

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-11 Thread Lachlan Andrew
Greetings all, On 11/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > > we should > get it right as it might have network driver interface implications. If you're redoing the driver interface, could I put in a request for packet time-stamping at a lower level? This thread started because TCP p

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-11 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 13:59:16 +0200 (EET) > How about this... > > ...I've left couple of FIXMEs there still, should be quite simple & > straightforward to handle them if this seems viable solution at all. > > Beware, this doesn't even compile yet beca

[RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one (Was: Re: [RFC] TCP illinois max rtt aging)

2007-12-11 Thread Ilpo Järvinen
x27;ll try to give some thought to this over the weekend. How about this... ...I've left couple of FIXMEs there still, should be quite simple & straightforward to handle them if this seems viable solution at all. Beware, this doesn't even compile yet because not all parameters are