Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-15 Thread Sergei Shtylyov
Hello. On 6/15/2015 4:52 PM, Scott Feldman wrote: From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device and maybe even unique for a sub-set of ports within device, so add switchdev helper function to generate unique marks based on

Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-15 Thread Scott Feldman
On Sun, Jun 14, 2015 at 10:46 PM, Jiri Pirko j...@resnulli.us wrote: Sun, Jun 14, 2015 at 07:50:13PM CEST, sfel...@gmail.com wrote: On Sat, Jun 13, 2015 at 11:56 PM, Jiri Pirko j...@resnulli.us wrote: Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote: From: Scott Feldman

Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-15 Thread roopa
On 6/13/15, 11:04 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device and maybe even unique for a sub-set of ports within device, so add switchdev helper function to generate unique marks based on

Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-14 Thread Jiri Pirko
Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device and maybe even unique for a sub-set of ports within device, so add switchdev helper function to generate unique marks based

Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-14 Thread Scott Feldman
On Sat, Jun 13, 2015 at 11:56 PM, Jiri Pirko j...@resnulli.us wrote: Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device and maybe even unique for a sub-set of ports within

Re: [RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-14 Thread Jiri Pirko
Sun, Jun 14, 2015 at 07:50:13PM CEST, sfel...@gmail.com wrote: On Sat, Jun 13, 2015 at 11:56 PM, Jiri Pirko j...@resnulli.us wrote: Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique

[RFC PATCH net-next 2/4] switchdev: add fwd_mark generator helper

2015-06-13 Thread sfeldma
From: Scott Feldman sfel...@gmail.com skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device and maybe even unique for a sub-set of ports within device, so add switchdev helper function to generate unique marks based on driver-supplied key. Typically, the driver would use