Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-28 Thread Davide Caratti
On Mon, 2017-02-27 at 07:11 -0800, Tom Herbert wrote: > CHECKSUM_PARTIAL is the preferred mechanism on the transmit path this > defers defers the checksum computation as long as possible. > Unfortunately, if SCTP is encapsulated in UDP we will probably need to > run the SCTP CRC on the host which

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-27 Thread Davide Caratti
On Mon, 2017-01-23 at 12:59 -0800, Tom Herbert wrote: > > > > It might make sense to create some CRC helper functions, but last time > > > > I checked there are so few users of CRC in skbufs I'm not even sure > > > > that would make sense. hello Tom and David, after some (thinking + testing)

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-27 Thread Tom Herbert
On Mon, Feb 27, 2017 at 5:39 AM, Davide Caratti wrote: > On Mon, 2017-01-23 at 12:59 -0800, Tom Herbert wrote: >> > > > It might make sense to create some CRC helper functions, but last time >> > > > I checked there are so few users of CRC in skbufs I'm not even sure >> > > >

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-02 Thread Tom Herbert
On Thu, Feb 2, 2017 at 7:07 AM, Davide Caratti wrote: > hello Tom and David, > > thank you for the attention. > >> From: Tom Herbert >> > >> > Sent: 23 January 2017 21:00 >> .. >> > >> > skb_checksum_help is specific to the Internet checksum. For instance, >> >

RE: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-02 Thread David Laight
From: Davide Caratti > Sent: 02 February 2017 15:07 > > From: Tom Herbert > > > > > > Sent: 23 January 2017 21:00 > > .. > > > > > > skb_checksum_help is specific to the Internet checksum. For instance, > > > CHECKSUM_COMPLETE can _only_ refer to Internet checksum calculation > > > nothing else

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-02-02 Thread Davide Caratti
hello Tom and David, thank you for the attention. > From: Tom Herbert > > > > Sent: 23 January 2017 21:00 > .. > > > > skb_checksum_help is specific to the Internet checksum. For instance, > > CHECKSUM_COMPLETE can _only_ refer to Internet checksum calculation > > nothing else will work.

RE: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-01-24 Thread David Laight
From: Tom Herbert > Sent: 23 January 2017 21:00 .. > skb_checksum_help is specific to the Internet checksum. For instance, > CHECKSUM_COMPLETE can _only_ refer to Internet checksum calculation > nothing else will work. Checksums and CRCs are very different things > with very different processing.

Re: [RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-01-23 Thread Tom Herbert
On Mon, Jan 23, 2017 at 8:52 AM, Davide Caratti wrote: > skb_checksum_help is designed to compute the Internet Checksum only. To > avoid duplicating code when other checksumming algorithms (e.g. crc32c) > are used, separate common part from RFC1624-specific part. > >

[RFC PATCH net-next 2/5] net: split skb_checksum_help

2017-01-23 Thread Davide Caratti
skb_checksum_help is designed to compute the Internet Checksum only. To avoid duplicating code when other checksumming algorithms (e.g. crc32c) are used, separate common part from RFC1624-specific part. Reviewed-by: Marcelo Ricardo Leitner Signed-off-by: Davide Caratti