Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-15 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 5:56 PM, Jiri Pirko wrote: > Wed, Mar 14, 2018 at 12:23:59PM CET, gerlitz...@gmail.com wrote: >>On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: >>> Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: On Wed, Mar 7,

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Jiri Pirko
Wed, Mar 14, 2018 at 12:23:59PM CET, gerlitz...@gmail.com wrote: >On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: >> Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >>>On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > >>>This sounds

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Jiri Pirko
Wed, Mar 14, 2018 at 02:50:02AM CET, jakub.kicin...@netronome.com wrote: >On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1 VF rep --> uplink 0 >> > 2.2 VF

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: > Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >>On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >>This sounds nice for the case where one install ingress tc rules on >>the bond (lets

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Jiri Pirko
Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >> Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>>If a

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-14 Thread Or Gerlitz
On Wed, Mar 14, 2018 at 3:50 AM, Jakub Kicinski wrote: > On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1 VF rep --> uplink 0

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Jakub Kicinski
On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: > > Starting with type 2, in our current NIC HW APIs we have to duplicate > > these rules > > into two rules set to HW: > > > > 2.1 VF rep --> uplink 0 > > 2.2 VF rep --> uplink 1 > > > > and we do that in the driver (add/del two HW rules,

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Or Gerlitz
On Tue, Mar 13, 2018 at 5:51 PM, Or Gerlitz wrote: Sorry ppl, I added MLNX alias (asap_direct_...@mellanox.com) which is not open to outer posts, please remove it from your replies, otherwise it will bump you back.. Or. > On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-13 Thread Or Gerlitz
On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>If a netdev has registered and is a slave of a given bond, then any tc >>rules

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-07 Thread Jiri Pirko
Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >Allow drivers to register netdev callbacks for tc offload in linux bonds. >If a netdev has registered and is a slave of a given bond, then any tc >rules offloaded to the bond will be relayed to it if both the bond and the

[RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-05 Thread John Hurley
Allow drivers to register netdev callbacks for tc offload in linux bonds. If a netdev has registered and is a slave of a given bond, then any tc rules offloaded to the bond will be relayed to it if both the bond and the slave permit hw offload. Because the bond itself is not offloaded, just the