Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

On Sat, Dec 23, 2017 at 11:41 PM, Jerome Brunet wrote: > On Sat, 2017-12-23 at 22:49 +0100, Martin Blumenstingl wrote: >> while calculating this with a target frequency of 500MHz manually >> again I saw that there's a remainder of 10Mhz after the initial >> division. >>

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

On Sat, 2017-12-23 at 22:49 +0100, Martin Blumenstingl wrote: > while calculating this with a target frequency of 500MHz manually > again I saw that there's a remainder of 10Mhz after the initial > division. > remainder * SDM_DEN = 16384000 - this value overflows 32-bit, > things will go

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

Hi Jerome, On Sat, Dec 23, 2017 at 9:40 PM, Jerome Brunet wrote: > On Sat, 2017-12-23 at 21:00 +0100, Martin Blumenstingl wrote: >> Hi Jerome, >> >> On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote: >> > On Sat, 2017-12-23 at 18:04 +0100, Martin

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

On Sat, 2017-12-23 at 21:00 +0100, Martin Blumenstingl wrote: > Hi Jerome, > > On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote: > > On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote: > > > Trying to set the rate of m250_div's parent clock makes no sense

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

Hi Jerome, On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote: > On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote: >> Trying to set the rate of m250_div's parent clock makes no sense since >> it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor >>

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

On Sat, 2017-12-23 at 18:40 +0100, Jerome Brunet wrote: > > Trying to set the rate of m250_div's parent clock makes no sense since > > it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor > > CLK_SET_RATE_PARENT set. > > It even does harm on Meson8b SoCs where the input clock for the mux > >

Re: [RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote: > Trying to set the rate of m250_div's parent clock makes no sense since > it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor > CLK_SET_RATE_PARENT set. > It even does harm on Meson8b SoCs where the input clock for the mux > cannot

[RFT net-next 2/2] net: stmmac: dwmac-meson8b: don't try to change m250_div parent's rate

Trying to set the rate of m250_div's parent clock makes no sense since it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor CLK_SET_RATE_PARENT set. It even does harm on Meson8b SoCs where the input clock for the mux cannot be divided down to 250MHz evenly (the parent rate is 52394Hz) which