Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-21 Thread Andrew Lunn
> However interesting as an example, I'm not convinced this is what we > should aim for. > > ACPI is not a replacement for DT, and it is unlikely that people would > be interested in running ACPI-only distros such as RHEL on their > Ethernet switch. DT is excellent at describing this, and there is

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-21 Thread Ard Biesheuvel
On 21 January 2018 at 16:13, Andrew Lunn wrote: >> Right. So if you need to have some additional "parameters" with the >> connection, then I suppose you may want to go with the GenericSerialBus >> route. However, looking at the sample device tree description: >> >> davinci_mdio: ethernet@5

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-21 Thread Andrew Lunn
> Right. So if you need to have some additional "parameters" with the > connection, then I suppose you may want to go with the GenericSerialBus > route. However, looking at the sample device tree description: > > davinci_mdio: ethernet@5c03 { > compatible = "ti,davinci_

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-21 Thread Mika Westerberg
On Sun, Jan 21, 2018 at 02:08:40AM +0100, Andrew Lunn wrote: > > I'm not familiar with MDIO bus but an alternative to GeneriSerialBus > > would be to follow what SDIO is doing, e.g have the PHY devices listed > > below the MDIO controller and use _ADR to describe their "address" on > > that bus. Yo

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-20 Thread Andrew Lunn
> I'm not familiar with MDIO bus but an alternative to GeneriSerialBus > would be to follow what SDIO is doing, e.g have the PHY devices listed > below the MDIO controller and use _ADR to describe their "address" on > that bus. You can see how _ADR applies to SDIO bus from ACPI spec. Hi Mika SDIO

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-20 Thread Mika Westerberg
On Fri, Jan 19, 2018 at 07:07:29PM +0100, Marcin Wojtas wrote: > Hi Mika, Hi, > 2018-01-18 14:00 GMT+01:00 Andrew Lunn : > >> I CC'ed Mika since he is more familiar with handling these bits of ACPI > >> specs - I wonder whether this is a problem that cropped up on x86 > >> systems too. > > > > Hi

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-19 Thread Andrew Lunn
> Since I have a code that can be tested and easily modified to use > different ACPI approaches with real platform MDIO controller > (mvmdio.c) and NIC (mvpp2.c), in coming weeks I may be able to find > some time to prepare a proof of concept based on GenericSerialBus. > Please expect some RFC patc

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-19 Thread Marcin Wojtas
Hi Mika, 2018-01-18 14:00 GMT+01:00 Andrew Lunn : >> I CC'ed Mika since he is more familiar with handling these bits of ACPI >> specs - I wonder whether this is a problem that cropped up on x86 >> systems too. > > Hi Lorenzo > > There is nothing about MDIO, PHYs, Ethernet switches, etc in version

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Andrew Lunn
> I CC'ed Mika since he is more familiar with handling these bits of ACPI > specs - I wonder whether this is a problem that cropped up on x86 > systems too. Hi Lorenzo There is nothing about MDIO, PHYs, Ethernet switches, etc in version 6.2 of the spec. If x86 has this, it must be after 6.2 was r

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread Lorenzo Pieralisi
[+cc Mika] On Tue, Jan 09, 2018 at 02:00:12PM +0100, Andrew Lunn wrote: > On Tue, Jan 09, 2018 at 11:22:00AM +0100, Marcin Wojtas wrote: > > 2018-01-09 11:19 GMT+01:00 Graeme Gregory : > > > On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > > >> Hi Andrew, > > >> > > >> > > >> > > >

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-09 Thread Andrew Lunn
On Tue, Jan 09, 2018 at 11:22:00AM +0100, Marcin Wojtas wrote: > 2018-01-09 11:19 GMT+01:00 Graeme Gregory : > > On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > >> Hi Andrew, > >> > >> > >> > >> 2018-01-08 16:42 GMT+01:00 Andrew Lunn : > >> > w> I am not familiar with MDIO, but if

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-09 Thread Marcin Wojtas
2018-01-09 11:19 GMT+01:00 Graeme Gregory : > On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: >> Hi Andrew, >> >> >> >> 2018-01-08 16:42 GMT+01:00 Andrew Lunn : >> > w> I am not familiar with MDIO, but if its similar or a specific >> >> implementation of a serial bus that does sound

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-09 Thread Graeme Gregory
On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > Hi Andrew, > > > > 2018-01-08 16:42 GMT+01:00 Andrew Lunn : > > w> I am not familiar with MDIO, but if its similar or a specific > >> implementation of a serial bus that does sound sane! > > > > Thanks for digging, I will check if

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Marcin Wojtas
Hi Andrew, 2018-01-08 16:42 GMT+01:00 Andrew Lunn : > w> I am not familiar with MDIO, but if its similar or a specific >> implementation of a serial bus that does sound sane! > Thanks for digging, I will check if and how we can use GenericSerialBus with MDIO. Best regards, Marcin > It is a tw

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Andrew Lunn
w> I am not familiar with MDIO, but if its similar or a specific > implementation of a serial bus that does sound sane! It is a two wire serial bus. A good overview can be found here: https://www.totalphase.com/support/articles/200349206-MDIO-Background Andrew

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Mon, Jan 08, 2018 at 03:53:12PM +0100, Andrew Lunn wrote: > On Mon, Jan 08, 2018 at 02:45:48PM +, Graeme Gregory wrote: > > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > > > I already agreed with 'reg' being awkward in the later emails. > > > > > Wouldn't _ADR be more ap

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Andrew Lunn
On Mon, Jan 08, 2018 at 02:45:48PM +, Graeme Gregory wrote: > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > > I already agreed with 'reg' being awkward in the later emails. > > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > > > > Ah it is

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > I already agreed with 'reg' being awkward in the later emails. > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > > Ah it is an actual address, then yes _ADR is probably more appropriate. > > Newbi

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-04 Thread Andrew Lunn
> > I already agreed with 'reg' being awkward in the later emails. > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > Ah it is an actual address, then yes _ADR is probably more appropriate. Newbie ACPI question. What is the definition of an address? In this cause, we

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-04 Thread Graeme Gregory
On Wed, Jan 03, 2018 at 12:12:06PM +0100, Marcin Wojtas wrote: > Hi Graeme, > > 2018-01-03 12:00 GMT+01:00 Graeme Gregory : > > On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: > >> On 18 December 2017 at 10:17, Marcin Wojtas wrote: > >> > Hi, > >> > > >> > This patchset introduces

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Marcin Wojtas
2018-01-03 14:33 GMT+01:00 Andrew Lunn : > On Wed, Jan 03, 2018 at 02:13:09PM +0100, Marcin Wojtas wrote: >> Hi Andrew, >> >> 2018-01-03 13:47 GMT+01:00 Andrew Lunn : >> >> I already agreed with 'reg' being awkward in the later emails. >> >> Wouldn't _ADR be more appropriate to specify PHY address

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Andrew Lunn
On Wed, Jan 03, 2018 at 02:13:09PM +0100, Marcin Wojtas wrote: > Hi Andrew, > > 2018-01-03 13:47 GMT+01:00 Andrew Lunn : > >> I already agreed with 'reg' being awkward in the later emails. > >> Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > Also, how do you specify w

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Marcin Wojtas
Hi Andrew, 2018-01-03 13:47 GMT+01:00 Andrew Lunn : >> I already agreed with 'reg' being awkward in the later emails. >> Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > Also, how do you specify which MDIO bus the PHY is on. To fully > specify a PHY, you need both bits of

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Andrew Lunn
> I already agreed with 'reg' being awkward in the later emails. > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? Also, how do you specify which MDIO bus the PHY is on. To fully specify a PHY, you need both bits of information. In DT, the phy-handle phandle can point to any

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Marcin Wojtas
Hi Graeme, 2018-01-03 12:00 GMT+01:00 Graeme Gregory : > On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: >> On 18 December 2017 at 10:17, Marcin Wojtas wrote: >> > Hi, >> > >> > This patchset introduces ACPI support in mvpp2 and mvmdio drivers. >> > First three patches introduce f

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Graeme Gregory
On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: > On 18 December 2017 at 10:17, Marcin Wojtas wrote: > > Hi, > > > > This patchset introduces ACPI support in mvpp2 and mvmdio drivers. > > First three patches introduce fwnode helpers for obtaining PHY > > information from nodes and

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-21 Thread Antoine Tenart
Hi Marcin, On Mon, Dec 18, 2017 at 10:17:56AM +0100, Marcin Wojtas wrote: > > Marcin Wojtas (8): > device property: Introduce fwnode_get_mac_address() > device property: Introduce fwnode_get_phy_mode() > mdio_bus: Introduce fwnode MDIO helpers > net: mvmdio: add ACPI support > net: mvpp

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-19 Thread Marcin Wojtas
Hi Andrew, 2017-12-19 21:46 GMT+01:00 Andrew Lunn : >> Of course! v2 will not have such problem, I've been waiting however >> for the feedback about the ACPI representation. Anyway, I'm strongly >> leaning towards using _ADR/_CID objects in PHY's nodes for ACPI, so >> maybe I'll just issue the v2

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-19 Thread Andrew Lunn
> Of course! v2 will not have such problem, I've been waiting however > for the feedback about the ACPI representation. Anyway, I'm strongly > leaning towards using _ADR/_CID objects in PHY's nodes for ACPI, so > maybe I'll just issue the v2 in order to push the discussion a bit > forward. Hi Mar

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-19 Thread Marcin Wojtas
Hi David, 2017-12-19 19:48 GMT+01:00 David Miller : > From: Marcin Wojtas > Date: Mon, 18 Dec 2017 10:17:56 +0100 > >> Above support configures 1G to use its PHY normally. 10G can work now >> only with the link interrupt mode. Somehow reading of the >> string property in fwnode_mdiobus_child_is_p

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-19 Thread David Miller
From: Marcin Wojtas Date: Mon, 18 Dec 2017 10:17:56 +0100 > Above support configures 1G to use its PHY normally. 10G can work now > only with the link interrupt mode. Somehow reading of the > string property in fwnode_mdiobus_child_is_phy works only with > DT and cannot cope with 10G PHY nodes as

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Marcin Wojtas
Hi Ard 2017-12-18 10:40 GMT+01:00 Ard Biesheuvel : > On 18 December 2017 at 10:17, Marcin Wojtas wrote: >> Hi, >> >> This patchset introduces ACPI support in mvpp2 and mvmdio drivers. >> First three patches introduce fwnode helpers for obtaining PHY >> information from nodes and also MDIO fwnode

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Rafael J. Wysocki
On 12/18/2017 10:17 AM, Marcin Wojtas wrote: Hi, This patchset introduces ACPI support in mvpp2 and mvmdio drivers. First three patches introduce fwnode helpers for obtaining PHY information from nodes and also MDIO fwnode API for registering the bus with its PHY/devices. Following patches upda

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Ard Biesheuvel
On 18 December 2017 at 10:17, Marcin Wojtas wrote: > Hi, > > This patchset introduces ACPI support in mvpp2 and mvmdio drivers. > First three patches introduce fwnode helpers for obtaining PHY > information from nodes and also MDIO fwnode API for registering > the bus with its PHY/devices. > > Fol

[net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Marcin Wojtas
Hi, This patchset introduces ACPI support in mvpp2 and mvmdio drivers. First three patches introduce fwnode helpers for obtaining PHY information from nodes and also MDIO fwnode API for registering the bus with its PHY/devices. Following patches update code of the mvmdio and mvpp2 drivers to supp