Re: [net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread Andrew Lunn 
On Sat, Nov 11, 2017 at 06:42:21PM +0900, David Miller wrote:
> From: kbuild test robot 
> Date: Sat, 11 Nov 2017 16:57:08 +0800
> 
> > All errors (new ones prefixed by >>):
> > 
> >net/dsa/port.o: In function `dsa_port_vlan_add':
> >>> net/dsa/port.c:255: undefined reference to `br_vlan_enabled'
> >net/dsa/port.o: In function `dsa_port_vlan_del':
> >net/dsa/port.c:270: undefined reference to `br_vlan_enabled'
> 
> Problem is NET_DSA=y and BRIDGE_VLAN_FILTERING=m
> 
> We need some Kconfig dependency foo to prevent this.

Yes. Lets see if i can put together a patch before Arnd!

 Andrew

Re: [net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread David Miller 
From: kbuild test robot 
Date: Sat, 11 Nov 2017 16:57:08 +0800

> All errors (new ones prefixed by >>):
> 
>net/dsa/port.o: In function `dsa_port_vlan_add':
>>> net/dsa/port.c:255: undefined reference to `br_vlan_enabled'
>net/dsa/port.o: In function `dsa_port_vlan_del':
>net/dsa/port.c:270: undefined reference to `br_vlan_enabled'

Problem is NET_DSA=y and BRIDGE_VLAN_FILTERING=m

We need some Kconfig dependency foo to prevent this.

[net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread kbuild test robot 
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
master
head:   bee955cd3ab4f1a1eb8fc16e7ed69364143df8d7
commit: 2ea7a679ca2abd251c1ec03f20508619707e1749 [622/639] net: dsa: Don't add 
vlans when vlan filtering is disabled
config: x86_64-randconfig-s2-1208 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 2ea7a679ca2abd251c1ec03f20508619707e1749
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/dsa/port.o: In function `dsa_port_vlan_add':
>> net/dsa/port.c:255: undefined reference to `br_vlan_enabled'
   net/dsa/port.o: In function `dsa_port_vlan_del':
   net/dsa/port.c:270: undefined reference to `br_vlan_enabled'

vim +255 net/dsa/port.c

   243  
   244  int dsa_port_vlan_add(struct dsa_port *dp,
   245const struct switchdev_obj_port_vlan *vlan,
   246struct switchdev_trans *trans)
   247  {
   248  struct dsa_notifier_vlan_info info = {
   249  .sw_index = dp->ds->index,
   250  .port = dp->index,
   251  .trans = trans,
   252  .vlan = vlan,
   253  };
   254  
 > 255  if (br_vlan_enabled(dp->bridge_dev))
   256  return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_ADD, 
&info);
   257  
   258  return 0;
   259  }
   260  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip