RE: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

2017-08-15 Thread David Laight
From: Keller, Jacob E > Sent: 14 August 2017 23:11 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Saturday, August 12, 2017 1:04 PM > > From: Jeff Kirsher > > Date: Sat, 12 Aug 2017 04:08:41 -0700 > > > > > Also ensure that the flags variable is

RE: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

2017-08-14 Thread Keller, Jacob E
edhat.com; sassm...@redhat.com; jogre...@redhat.com > Subject: Re: [net-next 08/15] i40e/i40evf: organize and re-number feature > flags > > From: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > Date: Sat, 12 Aug 2017 04:08:41 -0700 > > > Also ensure that the flags variab

Re: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

2017-08-12 Thread David Miller
From: Jeff Kirsher Date: Sat, 12 Aug 2017 04:08:41 -0700 > Also ensure that the flags variable is actually a u64 to guarantee > 64bits of space on all architectures. Why? You don't need 64-bits, you only need 27. This will be unnecessarily expensive on 32-bit

[net-next 08/15] i40e/i40evf: organize and re-number feature flags

2017-08-12 Thread Jeff Kirsher
From: Jacob Keller Now that we've reduced the number of flags, organize similar flags together and re-number them accordingly. Also ensure that the flags variable is actually a u64 to guarantee 64bits of space on all architectures. One alternative approach considered,