[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-03 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161126-202438 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-30 Thread Lino Sanfilippo
On 29.11.2016 18:14, Florian Fainelli wrote: > On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: >> The problem is that the HW does not provide a tx completion index. Instead >> we have to >> iterate the status descriptors until we get an invalid idx which indicates >> that there >> are no

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-29 Thread Florian Fainelli
On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: > The problem is that the HW does not provide a tx completion index. Instead we > have to > iterate the status descriptors until we get an invalid idx which indicates > that there > are no further tx descriptors done for now. I am afraid that if

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-29 Thread Markus Böhme
On 11/28/2016 09:46 PM, Lino Sanfilippo wrote: > Hi Markus, > > On 27.11.2016 18:59, Markus Böhme wrote: >> Hello Lino, >> >> just some things barely worth mentioning: >> > >> >> I found a bunch of unused #defines in slic.h. I cannot judge if they are >> worth keeping: >> >>

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-28 Thread Lino Sanfilippo
Hi Florian, On 28.11.2016 05:56, Florian Fainelli wrote: > On 11/26/2016 04:20 AM, Lino Sanfilippo wrote: >> Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer >> interface control) technology. The driver provides basic support without >> SLIC for the following devices: >>

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-28 Thread Lino Sanfilippo
Hi Markus, On 27.11.2016 18:59, Markus Böhme wrote: > Hello Lino, > > just some things barely worth mentioning: > > > I found a bunch of unused #defines in slic.h. I cannot judge if they are > worth keeping: > > SLIC_VRHSTATB_LONGE > SLIC_VRHSTATB_PREA > SLIC_ISR_IO >

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-27 Thread Florian Fainelli
On 11/26/2016 04:20 AM, Lino Sanfilippo wrote: > Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer > interface control) technology. The driver provides basic support without > SLIC for the following devices: > > - Mojave cards (single port PCI Gigabit) both copper and

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-27 Thread Markus Böhme
Hello Lino, just some things barely worth mentioning: On 11/26/2016 01:20 PM, Lino Sanfilippo wrote: > Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer > interface control) technology. The driver provides basic support without > SLIC for the following devices: > > -

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
Hi Rami, On 26.11.2016 16:48, Rami Rosen wrote: >> @@ -0,0 +1,28 @@ >> +config NET_VENDOR_ALACRITECH >> +bool "Alacritech devices" >> +default y >> +---help--- >> + If you have a network (Ethernet) card belonging to this class, >> say Y. >> + >> + Note

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Rami Rosen
Hi, Lino, ... > @@ -0,0 +1,28 @@ > +config NET_VENDOR_ALACRITECH > +bool "Alacritech devices" > +default y > +---help--- > + If you have a network (Ethernet) card belonging to this class, say > Y. > + > + Note that the answer to this question doesn't

[PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161125-190558 config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

Aw: Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread Lino Sanfilippo
Hi, > > On Fri, Nov 25, 2016 at 12:13:04AM +0100, Lino Sanfilippo wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2015,6 +2015,24 @@ > > #define PCI_SUBDEVICE_ID_CCD_OV4S 0xE888 > > #define PCI_SUBDEVICE_ID_CCD_OV8S 0xE998 > > > > +#define

Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread Greg KH
On Fri, Nov 25, 2016 at 12:13:04AM +0100, Lino Sanfilippo wrote: > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2015,6 +2015,24 @@ > #define PCI_SUBDEVICE_ID_CCD_OV4S0xE888 > #define PCI_SUBDEVICE_ID_CCD_OV8S0xE998 > > +#define PCI_VENDOR_ID_ALACRITECH

[PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)

Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
emloft.net, > char...@alacritech.com, lio...@gmail.com, gre...@linuxfoundation.org, > de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org, > netdev@vger.kernel.org > Betreff: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit > ethernet driver > > On 15.11.2016 22:59, An

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 16.11.2016 00:03, Andrew Lunn wrote: >> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | >> > + SLIC_PCR_AUTONEG_RST; >> > + slic_write(sdev, SLIC_REG_WPHY, val); > >> Thats essentially what I meant by setting a

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | > > +SLIC_PCR_AUTONEG_RST; > > + slic_write(sdev, SLIC_REG_WPHY, val); > Thats essentially what I meant by setting a flag in the irq handler. The mdio > function

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 23:39, Florian Fainelli wrote: > On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: >> On 15.11.2016 22:59, Andrew Lunn wrote: The link state is retrieved by a command to the application processor that is running on the network card. Also the register to set the phy

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: > On 15.11.2016 22:59, Andrew Lunn wrote: >>> The link state is retrieved by a command to the application processor that >>> is running >>> on the network card. Also the register to set the phy configuration is >>> write-only, so >>> it is not even

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 22:59, Andrew Lunn wrote: >> The link state is retrieved by a command to the application processor that >> is running >> on the network card. Also the register to set the phy configuration is >> write-only, so >> it is not even possible to do the usual mdio bit-banging in the Phy

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> The link state is retrieved by a command to the application processor that is > running > on the network card. Also the register to set the phy configuration is > write-only, so > it is not even possible to do the usual mdio bit-banging in the Phy read() > and write() > functions (however

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 15.11.2016 21:54, Florian Fainelli wrote: > On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >>> Could this be pulled out into a standard PHY driver? All the SLIC >>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >>> be a standard PHY hidden behind a single register.

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >> Could this be pulled out into a standard PHY driver? All the SLIC >> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >> be a standard PHY hidden behind a single register. >> >>Andrew > > You are right, the driver should

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 13.11.2016 20:55, Andrew Lunn wrote: >> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { >> +"rx_packets ", >> +"rx_bytes ", >> +"rx_multicasts ", >> +"rx_errors ", >> +"rx_buff_miss ", >> +"rx_tp_csum ", >> +"rx_tp_oflow",

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-13 Thread Andrew Lunn
> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { > + "rx_packets ", > + "rx_bytes ", > + "rx_multicasts ", > + "rx_errors ", > + "rx_buff_miss ", > + "rx_tp_csum ", > + "rx_tp_oflow", > + "rx_tp_hlen ", > + "rx_ip_csum

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-13 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9)

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread kbuild test robot
Hi Lino, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

[net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit)