Re: [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-13 Thread Jamal Hadi Salim
On 16-06-13 08:21 AM, Daniel Borkmann wrote: Looks like nft_meta_set_eval() can already do that, but restricted via pkt_type_ok(), so we can't play bad games with PACKET_LOOPBACK et al. Wasn't aware of that. Hm, so if you want to make use of this from tc as well, probably it makes sense to add

Re: [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-13 Thread Daniel Borkmann
On 06/13/2016 01:52 PM, Jamal Hadi Salim wrote: On 16-06-13 04:00 AM, Daniel Borkmann wrote: Hi Jamal, On 06/12/2016 11:24 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address

Re: [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-13 Thread Jamal Hadi Salim
On 16-06-13 04:00 AM, Daniel Borkmann wrote: Hi Jamal, On 06/12/2016 11:24 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac

Re: [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-13 Thread Daniel Borkmann
Hi Jamal, On 06/12/2016 11:24 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Signed-off-by: Jamal Hadi Salim

[net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-12 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Signed-off-by: Jamal Hadi Salim --- include/net/tc_act/tc_skbedit.h| 10