Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-27 Thread Nambiar, Amritha
On 6/27/2018 3:47 AM, Willem de Bruijn wrote: +static int get_xps_queue(struct net_device *dev, struct sk_buff *skb) { #ifdef CONFIG_XPS struct xps_dev_maps *dev_maps; - struct xps_map *map; + struct sock *sk = skb->sk; int

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-27 Thread Willem de Bruijn
> >> +static int get_xps_queue(struct net_device *dev, struct sk_buff *skb) > >> { > >> #ifdef CONFIG_XPS > >> struct xps_dev_maps *dev_maps; > >> - struct xps_map *map; > >> + struct sock *sk = skb->sk; > >> int queue_index = -1; > >> > >> if

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-26 Thread Nambiar, Amritha
On 6/26/2018 4:04 AM, Willem de Bruijn wrote: > On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar > wrote: >> >> This patch adds support to pick Tx queue based on the Rx queue(s) map >> configuration set by the admin through the sysfs attribute >> for each Tx queue. If the user configuration for

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-26 Thread Willem de Bruijn
On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar wrote: > > This patch adds support to pick Tx queue based on the Rx queue(s) map > configuration set by the admin through the sysfs attribute > for each Tx queue. If the user configuration for receive queue(s) map > does not apply, then the Tx queue

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-25 Thread kbuild test robot
Hi Amritha, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Amritha-Nambiar/Symmetric-queue-selection-using-XPS-for-Rx-queues/20180626-070944 config: i386-randconfig-x078-201825 (attached as .config)

[net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-25 Thread Amritha Nambiar
This patch adds support to pick Tx queue based on the Rx queue(s) map configuration set by the admin through the sysfs attribute for each Tx queue. If the user configuration for receive queue(s) map does not apply, then the Tx queue selection falls back to CPU(s) map based selection and finally to