RE: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-29 Thread Vakul Garg
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, July 29, 2018 11:48 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com > Subject: Re: [net-next v6 1/2] net/tls:

Re: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-29 Thread David Miller
From: Vakul Garg Date: Sun, 29 Jul 2018 06:01:29 + > Could you please correct me if my counter-reasoning behind changing > the socket callback is wrong? Ok, after stufying the code a bit I agree with your analysis.

RE: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-29 Thread Vakul Garg
bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com > Subject: RE: [net-next v6 1/2] net/tls: Use socket data_ready callback on > record availability > > > > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Wedn

RE: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-24 Thread Vakul Garg
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, July 25, 2018 1:43 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com > Subject: Re: [net-next v6 1/2] net/tls:

Re: [net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-24 Thread David Miller
From: Vakul Garg Date: Tue, 24 Jul 2018 15:44:02 +0530 > On receipt of a complete tls record, use socket's saved data_ready > callback instead of state_change callback. > > Signed-off-by: Vakul Garg I don't think this is correct. Here, the stream parser has given us a complete TLS record.

[net-next v6 1/2] net/tls: Use socket data_ready callback on record availability

2018-07-23 Thread Vakul Garg
On receipt of a complete tls record, use socket's saved data_ready callback instead of state_change callback. Signed-off-by: Vakul Garg --- net/tls/tls_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 0c2d029c9d4c..fee1240eff92