Re: [net v2] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails

2018-07-12 Thread David Miller
From: Jacob Keller Date: Tue, 10 Jul 2018 14:22:27 -0700 > When fq_codel_init fails, qdisc_create_dflt will cleanup by using > qdisc_destroy. This function calls the ->reset() op prior to calling the > ->destroy() op. > > Unfortunately, during the failure flow for sch_fq_codel, the ->flows > par

[net v2] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails

2018-07-10 Thread Jacob Keller
When fq_codel_init fails, qdisc_create_dflt will cleanup by using qdisc_destroy. This function calls the ->reset() op prior to calling the ->destroy() op. Unfortunately, during the failure flow for sch_fq_codel, the ->flows parameter is not initialized, so the fq_codel_reset function will null poi