Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-19 Thread Moni Shoua
Roland, Jay, Thanks a lot for the comments. I'd like to summarize the points raised so far 1. Reduce the indentation in patch #4 (Roland) I will resend 2. Remove the if (n-dev-flags IFF_MASTER) from patch #3 (Roland) I will resend 3. Consider making ipoib_slave_detach()

Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-19 Thread Roland Dreier
I think that if there are no other comments, I will submit the entire 11 patches again (with changes) to make it easier to merge into the kernel. Since the most of the content in the patch series is in bonding I thought it would be right that Jay will push all the patches to

Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-18 Thread Roland Dreier
Maybe this new notification function should be in net/core/dev.c instead of exporting call_netdevice_notifiers()? Or actually, does it work to add the call to the notifiers directly in unregister_netdev() so that device drivers don't have to worry about it? (And is the existing patch missing