Re: [patch 3/8] sundance: remove TxStartThresh and RxEarlyThresh

2006-11-07 Thread Jeff Garzik 

[EMAIL PROTECTED] wrote:

From: Jesse Huang [EMAIL PROTECTED]

For patent issue need to remove TxStartThresh and RxEarlyThresh.  This patent
is cut-through patent.  If use this function, Tx will start to transmit after
few data be move in to Tx FIFO.  We are not allow to use those function in
DFE530/DFE550/DFE580/DL10050/IP100/IP100A.  It will decrease a little
performance.

Signed-off-by: Jesse Huang [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]


applied


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 3/8] sundance: remove TxStartThresh and RxEarlyThresh

2006-10-22 Thread Philippe De Muyter 
On Fri, Oct 20, 2006 at 02:42:05PM -0700, [EMAIL PROTECTED] wrote:
 From: Jesse Huang [EMAIL PROTECTED]
 For patent issue need to remove TxStartThresh and RxEarlyThresh.  This patent
 is cut-through patent.  If use this function, Tx will start to transmit after
 few data be move in to Tx FIFO.  We are not allow to use those function in
 DFE530/DFE550/DFE580/DL10050/IP100/IP100A.  It will decrease a little
 performance.
[...]
 @@ -,6 +1109,7 @@ static irqreturn_t intr_handler(int irq,
   int tx_cnt;
   int tx_status;
   int handled = 0;
 + int i;

What the use here of adding this variable ? Is that actually a part of another
patch ?

  
  
   do {
 @@ -1153,17 +1152,14 @@ static irqreturn_t intr_handler(int irq,
   np-stats.tx_fifo_errors++;
   if (tx_status  0x02)
   np-stats.tx_window_errors++;
 +
   /*
   ** This reset has been verified on
   ** DFE-580TX boards ! [EMAIL PROTECTED]
   */
   if (tx_status  0x10) { /* TxUnderrun */
 - unsigned short txthreshold;
 -
 - txthreshold = ioread16 (ioaddr 
 + TxStartThresh);
   /* Restart Tx FIFO and 
 transmitter */
   sundance_reset(dev, 
 (NetworkReset|FIFOReset|TxReset)  16);
 - iowrite16 (txthreshold, ioaddr 
 + TxStartThresh);

I must be dense, but I do not understand how merely preserving the value of
a register across a reset can infringe on any patent

Philippe
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 3/8] sundance: remove TxStartThresh and RxEarlyThresh

2006-10-20 Thread akpm 
From: Jesse Huang [EMAIL PROTECTED]

For patent issue need to remove TxStartThresh and RxEarlyThresh.  This patent
is cut-through patent.  If use this function, Tx will start to transmit after
few data be move in to Tx FIFO.  We are not allow to use those function in
DFE530/DFE550/DFE580/DL10050/IP100/IP100A.  It will decrease a little
performance.

Signed-off-by: Jesse Huang [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---

 drivers/net/sundance.c |8 ++--
 1 files changed, 2 insertions(+), 6 deletions(-)

diff -puN 
drivers/net/sundance.c~sundance-remove-txstartthresh-and-rxearlythresh 
drivers/net/sundance.c
--- a/drivers/net/sundance.c~sundance-remove-txstartthresh-and-rxearlythresh
+++ a/drivers/net/sundance.c
@@ -264,8 +264,6 @@ enum alta_offsets {
ASICCtrl = 0x30,
EEData = 0x34,
EECtrl = 0x36,
-   TxStartThresh = 0x3c,
-   RxEarlyThresh = 0x3e,
FlashAddr = 0x40,
FlashData = 0x44,
TxStatus = 0x46,
@@ -,6 +1109,7 @@ static irqreturn_t intr_handler(int irq,
int tx_cnt;
int tx_status;
int handled = 0;
+   int i;
 
 
do {
@@ -1153,17 +1152,14 @@ static irqreturn_t intr_handler(int irq,
np-stats.tx_fifo_errors++;
if (tx_status  0x02)
np-stats.tx_window_errors++;
+
/*
** This reset has been verified on
** DFE-580TX boards ! [EMAIL PROTECTED]
*/
if (tx_status  0x10) { /* TxUnderrun */
-   unsigned short txthreshold;
-
-   txthreshold = ioread16 (ioaddr 
+ TxStartThresh);
/* Restart Tx FIFO and 
transmitter */
sundance_reset(dev, 
(NetworkReset|FIFOReset|TxReset)  16);
-   iowrite16 (txthreshold, ioaddr 
+ TxStartThresh);
/* No need to reset the Tx 
pointer here */
}
/* Restart the Tx. */
_
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html