Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

2017-06-14 Thread Jiri Pirko
Wed, Jun 14, 2017 at 09:28:24PM CEST, jb...@redhat.com wrote: >On Wed, 14 Jun 2017 21:18:50 +0200, Jiri Pirko wrote: >> Isn't it fixed by: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git/commit/?h=net-next&id=18f05d06016d9492c87fd105d831de0d6d858f43 >> >> ? > >Doesn'

Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

2017-06-14 Thread Jiri Benc
On Wed, 14 Jun 2017 21:18:50 +0200, Jiri Pirko wrote: > Isn't it fixed by: > > https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git/commit/?h=net-next&id=18f05d06016d9492c87fd105d831de0d6d858f43 > > ? Doesn't seem so. The current net-next branch with this commit included fails

Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

2017-06-14 Thread Jiri Pirko
Wed, Jun 14, 2017 at 08:32:22PM CEST, jb...@redhat.com wrote: >On Tue, 16 May 2017 19:29:36 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Each tc action is terminated by a control action. Each action parses and >> prints then intividually. Introduce set of helpers and allow to share >> this

Re: [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

2017-06-14 Thread Jiri Benc
On Tue, 16 May 2017 19:29:36 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Each tc action is terminated by a control action. Each action parses and > prints then intividually. Introduce set of helpers and allow to share > this code. This patch, as indicated by git bisect, broke tc if there are

[patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions

2017-05-16 Thread Jiri Pirko
From: Jiri Pirko Each tc action is terminated by a control action. Each action parses and prints then intividually. Introduce set of helpers and allow to share this code. Signed-off-by: Jiri Pirko --- tc/m_bpf.c| 8 ++-- tc/m_connmark.c | 4 +- tc/m_csum.c | 9 ++-- tc/m_