Re: [patch net-next 0/6] ipv4: fib: Provide per-nexthop offload indication

[David Miller]

From: Jiri Pirko 
Date: Wed,  2 Aug 2017 09:56:00 +0200

> From: Jiri Pirko 
> 
> Ido says:
> 
> Offload indication for IPv4 routes is currently set in the FIB info's
> flags. When multipath routes are employed, this can lead to a route being
> marked as offloaded although only one of its nexthops is actually
> offloaded.
> 
> Instead, this patchset aims to proivde a higher resolution for the offload
> indication and report it on a per-nexthop basis.
> 
> Example output from patched iproute:
> 
> $ ip route show 192.168.200.0/24
> 192.168.200.0/24
> nexthop via 192.168.100.2 dev enp3s0np7 weight 1 offload
> nexthop via 192.168.101.3 dev enp3s0np8 weight 1
> 
> And once the second gateway is resolved:
> 
> $ ip route show 192.168.200.0/24
> 192.168.200.0/24
> nexthop via 192.168.100.2 dev enp3s0np7 weight 1 offload
> nexthop via 192.168.101.3 dev enp3s0np8 weight 1 offload
> 
> First patch teaches the kernel to look for the offload indication in the
> nexthop flags. Patches 2-5 adjust current capable drivers to provide
> offload indication on a per-nexthop basis. Last patch removes no longer
> used functions to set offload indication in the FIB info's flags.

Series applied, thanks Jiri.

[patch net-next 0/6] ipv4: fib: Provide per-nexthop offload indication

[Jiri Pirko]

From: Jiri Pirko 

Ido says:

Offload indication for IPv4 routes is currently set in the FIB info's
flags. When multipath routes are employed, this can lead to a route being
marked as offloaded although only one of its nexthops is actually
offloaded.

Instead, this patchset aims to proivde a higher resolution for the offload
indication and report it on a per-nexthop basis.

Example output from patched iproute:

$ ip route show 192.168.200.0/24
192.168.200.0/24
nexthop via 192.168.100.2 dev enp3s0np7 weight 1 offload
nexthop via 192.168.101.3 dev enp3s0np8 weight 1

And once the second gateway is resolved:

$ ip route show 192.168.200.0/24
192.168.200.0/24
nexthop via 192.168.100.2 dev enp3s0np7 weight 1 offload
nexthop via 192.168.101.3 dev enp3s0np8 weight 1 offload

First patch teaches the kernel to look for the offload indication in the
nexthop flags. Patches 2-5 adjust current capable drivers to provide
offload indication on a per-nexthop basis. Last patch removes no longer
used functions to set offload indication in the FIB info's flags.

Ido Schimmel (6):
  ipv4: fib: Set offload indication according to nexthop flags
  rocker: Provide offload indication using nexthop flags
  mlxsw: spectrum_router: Provide offload indication using nexthop flags
  mlxsw: spectrum_router: Don't check state when refreshing offload
indication
  mlxsw: spectrum_router: Refresh offload indication upon group refresh
  ipv4: fib: Remove unused functions

 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  | 73 ++
 drivers/net/ethernet/rocker/rocker_ofdpa.c |  6 +-
 include/net/ip_fib.h   | 13 
 net/ipv4/fib_semantics.c   |  2 +
 4 files changed, 65 insertions(+), 29 deletions(-)

-- 
2.9.3