Re: [patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread Ido Schimmel
On Wed, Feb 08, 2017 at 11:05:54AM -0700, David Ahern wrote: > On 2/8/17 8:32 AM, Ido Schimmel wrote: > > In the case of multipath routes, if some of the nexthops can be > > reflected, then we do so, but periodically ask the kernel to try and > > resolve the others. Otherwise, these nexthops will

Re: [patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread David Ahern
On 2/8/17 8:32 AM, Ido Schimmel wrote: > In the case of multipath routes, if some of the nexthops can be > reflected, then we do so, but periodically ask the kernel to try and > resolve the others. Otherwise, these nexthops will never be resolved, as > the kernel doesn't see the packets hitting

Re: [patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread Ido Schimmel
On Wed, Feb 08, 2017 at 09:56:00AM -0500, Andy Gospodarek wrote: > On Wed, Feb 08, 2017 at 11:16:39AM +0100, Jiri Pirko wrote: > > From: Ido Schimmel > > > > When a multipath route is hit the kernel doesn't consider nexthops that > > are DEAD or LINKDOWN when

Re: [patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread Andy Gospodarek
On Wed, Feb 8, 2017 at 5:16 AM, Jiri Pirko wrote: > From: Ido Schimmel > > When a multipath route is hit the kernel doesn't consider nexthops that > are DEAD or LINKDOWN when IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN is set. > Devices that offload multipath routes

Re: [patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread Andy Gospodarek
On Wed, Feb 08, 2017 at 11:16:39AM +0100, Jiri Pirko wrote: > From: Ido Schimmel > > When a multipath route is hit the kernel doesn't consider nexthops that > are DEAD or LINKDOWN when IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN is set. > Devices that offload multipath routes need to

[patch net-next 12/15] ipv4: fib: Notify about nexthop status changes

2017-02-08 Thread Jiri Pirko
From: Ido Schimmel When a multipath route is hit the kernel doesn't consider nexthops that are DEAD or LINKDOWN when IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN is set. Devices that offload multipath routes need to be made aware of nexthop status changes. Otherwise, the device will