Re: [patch net-next RFC 10/12] nfp: flower: create port for flower vnic

2018-03-24 Thread Jiri Pirko
Sat, Mar 24, 2018 at 04:32:02AM CET, jakub.kicin...@netronome.com wrote: >On Fri, 23 Mar 2018 07:29:41 +0100, Jiri Pirko wrote: >> >This will associate the PF netdev with physical port, incl. all ethtool >> >information. Im not sure we want to do that. phy_repr carries this >> >functionality.

Re: [patch net-next RFC 10/12] nfp: flower: create port for flower vnic

2018-03-23 Thread Jakub Kicinski
On Fri, 23 Mar 2018 07:29:41 +0100, Jiri Pirko wrote: > >This will associate the PF netdev with physical port, incl. all ethtool > >information. Im not sure we want to do that. phy_repr carries this > >functionality. > > I was not sure originally what this port is. Okay, what I would like to

Re: [patch net-next RFC 10/12] nfp: flower: create port for flower vnic

2018-03-23 Thread Jiri Pirko
Fri, Mar 23, 2018 at 04:38:28AM CET, jakub.kicin...@netronome.com wrote: >On Thu, 22 Mar 2018 11:55:20 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/ethernet/netronome/nfp/flower/main.c | 3 +-- >> 1

Re: [patch net-next RFC 10/12] nfp: flower: create port for flower vnic

2018-03-22 Thread Jakub Kicinski
On Thu, 22 Mar 2018 11:55:20 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/netronome/nfp/flower/main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

[patch net-next RFC 10/12] nfp: flower: create port for flower vnic

2018-03-22 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- drivers/net/ethernet/netronome/nfp/flower/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c