Re: [v2] act_mirred: Fix bogus header when redirecting from VLAN

2015-04-17 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Fri, 17 Apr 2015 13:32:09 +0800 On Thu, Apr 16, 2015 at 07:40:30PM -0700, Alexei Starovoitov wrote: On Fri, Apr 17, 2015 at 10:15:01AM +0800, Herbert Xu wrote: seems the cleaner fix will be to push skb-mac_len instead? No skb-mac_len is

Re: [v2] act_mirred: Fix bogus header when redirecting from VLAN

2015-04-17 Thread Alexei Starovoitov
On Fri, Apr 17, 2015 at 01:32:09PM +0800, Herbert Xu wrote: When you redirect a VLAN device to any device, you end up with crap in af_packet on the xmit path because hard_header_len is not equal to skb-mac_len. So the redirected packet contains four extra bytes at the start which then gets

[v2] act_mirred: Fix bogus header when redirecting from VLAN

2015-04-16 Thread Herbert Xu
On Thu, Apr 16, 2015 at 07:40:30PM -0700, Alexei Starovoitov wrote: On Fri, Apr 17, 2015 at 10:15:01AM +0800, Herbert Xu wrote: seems the cleaner fix will be to push skb-mac_len instead? No skb-mac_len is the same as skb2-dev-hard_header_len. hmm. please help me understand the problem