Re: [v3,net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
Hi Andrew, Thank you for review and valuable comments. I will implement below suggestion and resend for review. Thanks, Raju. On Tue, Sep 27, 2016 at 11:14:36PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > I just realised the possibly correct binding was starring me in the > face. > > ---

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
Hi Andrew, Thank you for review and valuable comments. Thanks, Raju. On Tue, Sep 27, 2016 at 04:16:33PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > index 000..7ba3855 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > > @@ -0,0 +1,61 @@ > > +* Mi

Re: [v3,net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Andrew Lunn
I just realised the possibly correct binding was starring me in the face. --| | 3.3V 2.5V1.8V1.5V | |-| |-2%-3%

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Andrew Lunn
On Tue, Sep 27, 2016 at 04:26:59PM +0200, Allan W. Nielsen wrote: > Hi Andrew, > > > > +Optional properties: > > > +- vsc8531,edge-rate : Edge rate sets the drive strength of the MAC > > > + interface output signals. Changing the drive > > > + strength

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Allan W. Nielsen
Hi Andrew, > > +Optional properties: > > +- vsc8531,edge-rate : Edge rate sets the drive strength of the MAC > > + interface output signals. Changing the drive > > + strength will affect the edge rate of the output > > + signal. >

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Andrew Lunn
> index 000..7ba3855 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -0,0 +1,61 @@ > +* Microsemi - vsc8531 Giga bit ethernet phy > + > +Required properties: > +- compatible : Should contain phy id as "ethernet-phy-id." > + If the ph

[PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Raju Lakkaraju
From: Raju Lakkaraju All the review comments updated and resending for review. Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price i

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-26 Thread Andrew Lunn
On Mon, Sep 26, 2016 at 07:18:25PM +0530, Raju Lakkaraju wrote: > Hi, > > Thank you for review the code and valuable comments. > Summary of changes: > V1: Initial version of Edge-rate driver add by using IOCTL. > V2: Changed edge-rate parameter to Device Tree with magic number. >

[PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-26 Thread Raju Lakkaraju
Hi, Thank you for review the code and valuable comments. Summary of changes: V1: Initial version of Edge-rate driver add by using IOCTL. V2: Changed edge-rate parameter to Device Tree with magic number. V3: Added Device Tree documentatoin and edge-rate parameter table.