[PATCH 1/2] [IrDA] irda-usb TX path optimization (was Re: IrDA spams logfiles - since 2.6.19)

2007-01-15 Thread Samuel Ortiz
Hi Dave, Since we stop using dev_alloc_skb on the IrDA TX frame, we constantly run into the case of the skb headroom being 0, and thus we call skb_cow for every IrDA TX frame. This patch uses a local buffer and memcpy the skb to it, saving us a kmalloc for each of those IrDA TX frames.

Re: IrDA spams logfiles - since 2.6.19

2007-01-11 Thread Samuel Ortiz
Hi Dave, On Wed, Jan 10, 2007 at 03:26:07PM -0800, David Miller wrote: The warning is a bit extreme because the skb_cow() call does fix things up and makes space available. But it's not the most efficient thing in the world, so it's good that we know about this so we can have a closer work.

Re: IrDA spams logfiles - since 2.6.19

2007-01-10 Thread David Miller
From: Andreas Leitgeb [EMAIL PROTECTED] Date: Sun, 7 Jan 2007 01:51:50 +0100 As soon as I load the irda-usb module with the device plugged, I get lots of messages of following kind into the logs: irda_usb_hard_xmit(), Insuficient skb headroom. (the Insuficient-typo is original) about 7 in

IrDA spams logfiles - since 2.6.19

2007-01-06 Thread Andreas Leitgeb
I'm not on this list, so please keep me CC'ed on this thread. Since 2.6.19 I've got a problem with my Tekram IRmate 410U usb-irda-dongle. Until 2.6.18.3 (the latest I had before 2.6.19*) it worked just fine. 2.6.19.1 had another change in irda-usb but that didn't solve the problem. As soon as