Re: Leak in ipv6_gso_segment()?

2017-06-04 Thread David Miller
From: Craig Gallek Date: Fri, 2 Jun 2017 15:27:41 -0400 > On Fri, Jun 2, 2017 at 2:25 PM, Craig Gallek wrote: >> On Fri, Jun 2, 2017 at 2:05 PM, David Miller wrote: >>> From: Ben Hutchings >>> Date: Wed,

Re: Leak in ipv6_gso_segment()?

2017-06-02 Thread Craig Gallek
On Fri, Jun 2, 2017 at 2:25 PM, Craig Gallek wrote: > On Fri, Jun 2, 2017 at 2:05 PM, David Miller wrote: >> From: Ben Hutchings >> Date: Wed, 31 May 2017 13:26:02 +0100 >> >>> If I'm not mistaken, ipv6_gso_segment() now leaks

Re: Leak in ipv6_gso_segment()?

2017-06-02 Thread Craig Gallek
On Fri, Jun 2, 2017 at 2:05 PM, David Miller wrote: > From: Ben Hutchings > Date: Wed, 31 May 2017 13:26:02 +0100 > >> If I'm not mistaken, ipv6_gso_segment() now leaks segs if >> ip6_find_1stfragopt() fails. I'm not sure whether the fix would be as >>

Re: Leak in ipv6_gso_segment()?

2017-06-02 Thread David Miller
From: Ben Hutchings Date: Wed, 31 May 2017 13:26:02 +0100 > If I'm not mistaken, ipv6_gso_segment() now leaks segs if > ip6_find_1stfragopt() fails. I'm not sure whether the fix would be as > simple as adding a kfree_skb(segs) or whether more complex cleanup is > needed.

Leak in ipv6_gso_segment()?

2017-05-31 Thread Ben Hutchings
If I'm not mistaken, ipv6_gso_segment() now leaks segs if ip6_find_1stfragopt() fails. I'm not sure whether the fix would be as simple as adding a kfree_skb(segs) or whether more complex cleanup is needed. Ben. -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it