Re: MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[Geert Uytterhoeven]

Hi David,

On Tue, Nov 24, 2015 at 7:10 PM, David Miller  wrote:
> From: Geert Uytterhoeven 
> Date: Sun, 22 Nov 2015 11:03:18 +0100
>
>> Is there a reason why IP_MULTIPLE_TABLES and
>> IP_MROUTE_MULTIPLE_TABLES depend on IP_ADVANCED_ROUTER, while their
>> IPV6 counterparts don't?
>
> It's just another thing that happened to diverge over time, there is
> no real reason.

So should the dependencies be added for IPv6, or removed for IPv4?
Thanks again!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[Cong Wang]

On Tue, Nov 24, 2015 at 10:38 AM, Geert Uytterhoeven
 wrote:
> Hi David,
>
> On Tue, Nov 24, 2015 at 7:10 PM, David Miller  wrote:
>> From: Geert Uytterhoeven 
>> Date: Sun, 22 Nov 2015 11:03:18 +0100
>>
>>> Is there a reason why IP_MULTIPLE_TABLES and
>>> IP_MROUTE_MULTIPLE_TABLES depend on IP_ADVANCED_ROUTER, while their
>>> IPV6 counterparts don't?
>>
>> It's just another thing that happened to diverge over time, there is
>> no real reason.
>
> So should the dependencies be added for IPv6, or removed for IPv4?

David's point is we should just leave it as it is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[David Miller]

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[David Miller]

From: Geert Uytterhoeven 
Date: Sun, 22 Nov 2015 11:03:18 +0100

> Is there a reason why IP_MULTIPLE_TABLES and
> IP_MROUTE_MULTIPLE_TABLES depend on IP_ADVANCED_ROUTER, while their
> IPV6 counterparts don't?

It's just another thing that happened to diverge over time, there is
no real reason.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[David Miller]

From: Geert Uytterhoeven 
Date: Tue, 24 Nov 2015 19:38:13 +0100

> Hi David,
> 
> On Tue, Nov 24, 2015 at 7:10 PM, David Miller  wrote:
>> From: Geert Uytterhoeven 
>> Date: Sun, 22 Nov 2015 11:03:18 +0100
>>
>>> Is there a reason why IP_MULTIPLE_TABLES and
>>> IP_MROUTE_MULTIPLE_TABLES depend on IP_ADVANCED_ROUTER, while their
>>> IPV6 counterparts don't?
>>
>> It's just another thing that happened to diverge over time, there is
>> no real reason.
> 
> So should the dependencies be added for IPv6, or removed for IPv4?

I think either change risks breaking something for someone, for
extremely questionable gains, so leaving things as they are is
probably the most prudent thing to do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

MULTIPLE_TABLES and IP_ADVANCED_ROUTER

[Geert Uytterhoeven]

Hi,

Is there a reason why IP_MULTIPLE_TABLES and IP_MROUTE_MULTIPLE_TABLES
depend on IP_ADVANCED_ROUTER, while their IPV6 counterparts don't?

net/ipv4/Kconfig:

config IP_MULTIPLE_TABLES
bool "IP: policy routing"
depends on IP_ADVANCED_ROUTER
select FIB_RULES

config IP_MROUTE_MULTIPLE_TABLES
bool "IP: multicast policy routing"
depends on IP_MROUTE && IP_ADVANCED_ROUTER
select FIB_RULES


net/ipv6/Kconfig:

config IPV6_MULTIPLE_TABLES
bool "IPv6: Multiple Routing Tables"
select FIB_RULES

config IPV6_MROUTE_MULTIPLE_TABLES
bool "IPv6: multicast policy routing"
depends on IPV6_MROUTE
select FIB_RULES

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html