Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-31 Thread Simon Horman
On Thu, May 28, 2015 at 08:53:20AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:18 AM, David Laight david.lai...@aculab.com wrote: From: Simon Horman Sent: 28 May 2015 04:23 The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Jiri Pirko
Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. I don't understand reason for this patch. I like it

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Simon Horman
On Thu, May 28, 2015 at 08:15:42AM +0200, Jiri Pirko wrote: Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being

RE: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread David Laight
From: Simon Horman Sent: 28 May 2015 04:23 The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. If the arguments are passed in registers (they almost certainly are) or the

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:18 AM, David Laight david.lai...@aculab.com wrote: From: Simon Horman Sent: 28 May 2015 04:23 The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway.

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-27 Thread Scott Feldman
On Wed, May 27, 2015 at 8:23 PM, Simon Horman simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. Signed-off-by: Simon Horman