Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
On Wed, 2016-09-07 at 02:00 +, ronnie.ku...@microchip.com wrote: > Microchip's internal convention is for register (offset) definitions > to be capitalized (i.e.: MY_REGISTER). Our convention for bits > (position) definitions within a register is to carry as a prefix the > name of the register

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Ronnie.Kunin
Tuesday, September 06, 2016 9:18 PM To: Woojung Huh - C21699; netdev@vger.kernel.org; linux-...@vger.kernel.org Cc: f.faine...@gmail.com; UNGLinuxDriver; linux-ker...@vger.kernel.org Subject: Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros On Tue, 2016-09-06 at 23:19 +, woojun

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
On Tue, 2016-09-06 at 23:19 +, woojung@microchip.com wrote: > > Joe Perches (2): > >   lan78xx: Remove locally defined trailing underscores from defines and uses > >   microchipphy.h and uses: Remove trailing underscores from defines and > > uses > > > >  drivers/net/phy/microchip.c |

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Woojung.Huh
> Joe Perches (2): > lan78xx: Remove locally defined trailing underscores from defines and uses > microchipphy.h and uses: Remove trailing underscores from defines and > uses > > drivers/net/phy/microchip.c |4 +- > drivers/net/usb/lan78xx.c| 368 +++ >