RE: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread Joonwoo Park
2007/12/12, Joonwoo Park [EMAIL PROTECTED]: [NETDEV]: e1000 Fix possible causing oops of net_rx_action returning work_done == weight as true after calling netif_rx_complete will cause oops in net_rx_action. I tried two types of patches for oops and ifconfig down hang for e1000 first. Just

Re: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 19:18:56 +0900 Just blowing netif_running up is not best solution I think, it makes ifconfig down hang at least for e1000. It hangs because the packet receive rate is so high that NAPI poll never exits. I think we need a cheap

Re: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread Joonwoo Park
2007/12/13, David Miller [EMAIL PROTECTED]: From: Joonwoo Park [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 19:18:56 +0900 Just blowing netif_running up is not best solution I think, it makes ifconfig down hang at least for e1000. It hangs because the packet receive rate is so high that NAPI