On 8/2/2017 11:41 AM, Roopa Prabhu wrote:
> On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar
> wrote:
>> The Mirred/redirect action is extended to accept a traffic
>> class on the device in addition to the device's ifindex.
>>
>> Usage: mirred
>>
>> Example:
>> # tc
On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar
wrote:
> The Mirred/redirect action is extended to accept a traffic
> class on the device in addition to the device's ifindex.
>
> Usage: mirred
>
> Example:
> # tc qdisc add dev eth0 ingress
>
> # tc filter add dev
On 8/1/2017 8:12 AM, David Laight wrote:
> From: Stephen Hemminger
>> Sent: 01 August 2017 04:52
>> On Mon, 31 Jul 2017 17:40:50 -0700
>> Amritha Nambiar wrote:
>> The concept is fine, bu t the code looks different than the rest which
>> is never a good sign.
>>
>>
>>>
From: Stephen Hemminger
> Sent: 01 August 2017 04:52
> On Mon, 31 Jul 2017 17:40:50 -0700
> Amritha Nambiar wrote:
> The concept is fine, bu t the code looks different than the rest which
> is never a good sign.
>
>
> > + if ((argc > 0) &&
Amritha Nambiar writes:
[...]
> @@ -72,6 +73,8 @@ parse_direction(struct action_util *a, int *argc_p, char
> ***argv_p,
> struct tc_mirred p = {};
> struct rtattr *tail;
> char d[16] = {};
> + __u32 flags = 0;
> + __u8 tc;
>
> while
On Mon, 31 Jul 2017 17:40:50 -0700
Amritha Nambiar wrote:
The concept is fine, bu t the code looks different than the rest which
is never a good sign.
> + if ((argc > 0) && (matches(*argv, "tc") == 0)) {
Extra () are unnecessary in