Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-02 Thread Nambiar, Amritha
On 8/2/2017 11:41 AM, Roopa Prabhu wrote: > On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar > wrote: >> The Mirred/redirect action is extended to accept a traffic >> class on the device in addition to the device's ifindex. >> >> Usage: mirred >> >> Example: >> # tc

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-02 Thread Roopa Prabhu
On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar wrote: > The Mirred/redirect action is extended to accept a traffic > class on the device in addition to the device's ifindex. > > Usage: mirred > > Example: > # tc qdisc add dev eth0 ingress > > # tc filter add dev

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-02 Thread Nambiar, Amritha
On 8/1/2017 8:12 AM, David Laight wrote: > From: Stephen Hemminger >> Sent: 01 August 2017 04:52 >> On Mon, 31 Jul 2017 17:40:50 -0700 >> Amritha Nambiar wrote: >> The concept is fine, bu t the code looks different than the rest which >> is never a good sign. >> >> >>>

RE: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-01 Thread David Laight
From: Stephen Hemminger > Sent: 01 August 2017 04:52 > On Mon, 31 Jul 2017 17:40:50 -0700 > Amritha Nambiar wrote: > The concept is fine, bu t the code looks different than the rest which > is never a good sign. > > > > + if ((argc > 0) &&

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-01 Thread Roman Mashak
Amritha Nambiar writes: [...] > @@ -72,6 +73,8 @@ parse_direction(struct action_util *a, int *argc_p, char > ***argv_p, > struct tc_mirred p = {}; > struct rtattr *tail; > char d[16] = {}; > + __u32 flags = 0; > + __u8 tc; > > while

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2017 17:40:50 -0700 Amritha Nambiar wrote: The concept is fine, bu t the code looks different than the rest which is never a good sign. > + if ((argc > 0) && (matches(*argv, "tc") == 0)) { Extra () are unnecessary in