Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-04 Thread Bendik Rønning Opstad
On Monday, November 02, 2015 09:37:54 AM David Laight wrote: > From: Bendik Rønning Opstad > > Sent: 23 October 2015 21:50 > > RDB is a mechanism that enables a TCP sender to bundle redundant > > (already sent) data with TCP packets containing new data. By bundling > > (retransmitting) already

RE: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-02 Thread David Laight
From: Bendik Rønning Opstad > Sent: 23 October 2015 21:50 > RDB is a mechanism that enables a TCP sender to bundle redundant > (already sent) data with TCP packets containing new data. By bundling > (retransmitting) already sent data with each TCP packet containing new > data, the connection will

RE: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-02 Thread David Laight
From: Bendik Rønning Opstad > Sent: 29 October 2015 22:54 ... > > > > The semantics of the tp->nonagle bits are already a bit complex. My > > > > sense is that having a setsockopt of TCP_RDB transparently modify the > > > > nagle behavior is going to add more extra complexity and unanticipated > >

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-29 Thread Bendik Rønning Opstad
On Monday, October 26, 2015 02:58:03 PM Yuchung Cheng wrote: > On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > > > > >

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-27 Thread Jonas Markussen
On 26 Oct 2015, at 22:58, Yuchung Cheng wrote: > but would RDB be voided if this developer turns on RDB then turns on > Nagle later? The short answer is answer is "kind of" My understanding is that Nagle will delay segments until they're either MSS-sized or until segments

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Yuchung Cheng
On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > wrote: > >> @@ -2409,6 +2412,15 @@ static int

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Andreas Petlund
> On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > wrote: >> @@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int >> level, > ... >> + case TCP_RDB: >> +

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Neal Cardwell
On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad wrote: >@@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int level, ... > + case TCP_RDB: > + if (val < 0 || val > 1) { > + err = -EINVAL; > + }