RE: [PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-12-05 Thread Yuval Mintz
> > Isn't AE_VERSION_1 something fixed once you publish your features? > > If it can't be changed, why not simply remove the features from > > `hw_features' instead of having to implement this ndo? > There could be a case where the feature is supported by the SoC > and therefore it is already part

Re: [PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-12-01 Thread Salil Mehta
On 22/11/15 11:17, Yuval Mintz wrote: +static netdev_features_t hns_nic_fix_features( + struct net_device *netdev, netdev_features_t features) { + struct hns_nic_priv *priv = netdev_priv(netdev); + + switch (priv->enet_ver) { + case AE_VERSION_1: +

RE: [PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-22 Thread Yuval Mintz
> +static netdev_features_t hns_nic_fix_features( > + struct net_device *netdev, netdev_features_t features) { > + struct hns_nic_priv *priv = netdev_priv(netdev); > + > + switch (priv->enet_ver) { > + case AE_VERSION_1: > + features &= ~(NETIF_F_TSO |