Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: > Em 09-09-2015 17:30, Vlad Yasevich escreveu: >> On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: >>> Consider sctp module is unloaded and is being requested because an user >>> is creating a sctp socket. >>> >>> During initialization,

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initialization order inside register_pernet_subsys() so that the control socket is created by last and also block socket

RE: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 10 September 2015 13:54 > Em 09-09-2015 21:16, David Miller escreveu: > > From: Marcelo Ricardo Leitner > > Date: Wed, 9 Sep 2015 17:03:01 -0300 > > > >> So the fix then is to invert the initialization order inside > >>

RE: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread David Laight
From: Marcelo Ricardo > Sent: 10 September 2015 15:36 ... > > Given that the first ->create() blocks while the protocol code loads > > it really wouldn't be right to error a subsequent ->create() because > > the load hasn't completed. > > Can't say I don't agree with you, but at the same time,

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 10-09-2015 10:24, Vlad Yasevich escreveu: On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: Consider sctp module is unloaded and is being requested because an user is creating a sctp

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 10-09-2015 10:02, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 10 September 2015 13:54 Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initialization

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > Em 10-09-2015 10:24, Vlad Yasevich escreveu: >> On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: >>> Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: > Consider sctp module is

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: ... > >> Then you can order sctp_net_init() such that it happens first, then > >> protosw registration > >> happens, then

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: > ... > > >> Then you can order sctp_net_init()

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
On Thu, Sep 10, 2015 at 03:35:20PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > > > Em 10-09-2015

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Vlad Yasevich
On 09/10/2015 02:35 PM, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: >> On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: >>> On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: Em 10-09-2015 10:24, Vlad Yasevich

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-10 Thread Marcelo Ricardo Leitner
Em 10-09-2015 16:14, Vlad Yasevich escreveu: On 09/10/2015 02:35 PM, Marcelo Ricardo Leitner wrote: On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote:

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 9 Sep 2015 17:03:01 -0300 > So the fix then is to invert the initialization order inside > register_pernet_subsys() so that the control socket is created by last > and also block socket creation if netns initialization wasn't

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Vlad Yasevich
On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: > Consider sctp module is unloaded and is being requested because an user > is creating a sctp socket. > > During initialization, sctp will add the new protocol type and then > initialize pernet subsys: > > status =

Re: [PATCH net] sctp: fix race on protocol/netns initialization

2015-09-09 Thread Marcelo Ricardo Leitner
Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: Consider sctp module is unloaded and is being requested because an user is creating a sctp socket. During initialization, sctp will add the new protocol type and then initialize pernet subsys: