Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-09-01 Thread lucien xin
> > In addition to what David said and looking at it from a different angle... > 256 buckets > may not be enough for someone with a single endpoint and alot of > associations. You > will still hit a long chain on INIT and COOKIE-ECHO chunks. > > Switching to using rhashtable for association

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-09-01 Thread lucien xin
On Tue, Sep 1, 2015 at 6:16 AM, David Miller wrote: > From: Xin Long > Date: Tue, 1 Sep 2015 01:44:28 +0800 > >> @@ -524,18 +524,16 @@ static inline int sctp_assoc_hashfn(struct net *net, >> __u16 lport, __u16 rport) >> { >> int h = (lport <<

RE: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-09-01 Thread David Laight
From: Xin Long > Sent: 31 August 2015 18:44 > > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every assoc in server > will be

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-08-31 Thread lucien xin
attachment is the test script above-mentioned. sctperf.tar.gz Description: GNU Zip compressed data

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-08-31 Thread lucien xin
that patch is actually meant for net-next, need to state. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-08-31 Thread David Miller
From: Xin Long Date: Tue, 1 Sep 2015 01:44:28 +0800 > @@ -524,18 +524,16 @@ static inline int sctp_assoc_hashfn(struct net *net, > __u16 lport, __u16 rport) > { > int h = (lport << 16) + rport + net_hash_mix(net); > h ^= h>>8; > - return h &

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-08-31 Thread Vlad Yasevich
On 08/31/2015 01:44 PM, Xin Long wrote: > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every assoc in server > will be hashed in