RE: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

I'll submit patch for review. - Woojung > On 10/02/2016 15:18, woojung@microchip.com wrote: > >>> +static int lan88xx_config_init(struct phy_device *phydev) > >>> +{ > >>> + phydev->supported &= phydev->drv->features; > >>> + phydev->advertising &= phydev->drv->features; > >> > >> This looks

Re: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

On 10/02/16 13:13, woojung@microchip.com wrote: > > Update to set default phy supported & advertising features from phy device > structure and remove unnecessary code in the nic driver. > > Signed-off-by: Woojung Huh > --- > drivers/net/phy/microchip.c | 10

Re: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

On 10/02/2016 15:18, woojung@microchip.com wrote: >>> +static int lan88xx_config_init(struct phy_device *phydev) >>> +{ >>> + phydev->supported &= phydev->drv->features; >>> + phydev->advertising &= phydev->drv->features; >> >> This looks suspicious, phy_probe() takes the driver

RE: [PATCH net-next 2/3] lan78xx: setting phy features in phy driver

> > +static int lan88xx_config_init(struct phy_device *phydev) > > +{ > > + phydev->supported &= phydev->drv->features; > > + phydev->advertising &= phydev->drv->features; > > This looks suspicious, phy_probe() takes the driver supported features > and assigns it to phydev->supported, and