Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-10 Thread Sergei Shtylyov 

Hello!

On 7/10/2017 4:20 AM, Rob Herring wrote:


Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
family.


For the subject: "dt-bindings: net: ..."



Signed-off-by: Biju Das 
Reviewed-by: Chris Paterson 
---
  Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
  drivers/net/ethernet/renesas/ravb_main.c   | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b519503..bc692ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -4,7 +4,8 @@ This file provides information on what the device node for the 
Ethernet AVB
  interface contains.
  
  Required properties:

-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
SoC.
+- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 
SoC.
+ "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.


Please re-format like this:

- compatible: Must be one of:
...

So it's a one line change to add new compatibles.


   Note that the common gen2/3 values are at end of this list, so they'll 
need different treating if you add these words.


MBR, Sergei

RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-10 Thread Biju Das 
Hello,

Thanks for the review.

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: 10 July 2017 02:20
> To: Biju Das <biju@bp.renesas.com>
> Cc: Mark Rutland <mark.rutl...@arm.com>; Russell King
> <li...@armlinux.org.uk>; Sergei Shtylyov
> <sergei.shtyl...@cogentembedded.com>; Simon Horman
> <ho...@verge.net.au>; Magnus Damm <magnus.d...@gmail.com>; Chris
> Paterson <chris.paters...@renesas.com>; devicet...@vger.kernel.org; linux-
> renesas-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
>
> For the subject: "dt-bindings: net: ..."

I will change the subject to "dt-bindings: net: ravb: ..

>
> >
> > Signed-off-by: Biju Das <biju@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paters...@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> >  drivers/net/ethernet/renesas/ravb_main.c   | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..bc692ab 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,7 +4,8 @@ This file provides information on what the device node
> > for the Ethernet AVB  interface contains.
> >
> >  Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743
> SoC.
> > +  "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
Ok. I will change this as well.

> So it's a one line change to add new compatibles.
>
> >"renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >"renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >"renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv)  }
> >
> >  static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
> > --
> > 1.9.1
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-09 Thread Rob Herring 
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.

For the subject: "dt-bindings: net: ..."

> 
> Signed-off-by: Biju Das 
> Reviewed-by: Chris Paterson 
> ---
>  Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
>  drivers/net/ethernet/renesas/ravb_main.c   | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
> b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index b519503..bc692ab 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -4,7 +4,8 @@ This file provides information on what the device node for 
> the Ethernet AVB
>  interface contains.
>  
>  Required properties:
> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
> SoC.
> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 
> SoC.
> +   "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.

Please re-format like this:

- compatible: Must be one of:
...

So it's a one line change to add new compatibles.

> "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
> b/drivers/net/ethernet/renesas/ravb_main.c
> index 5931e85..e35b30f 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
>  }
>  
>  static const struct of_device_id ravb_match_table[] = {
> + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
>   { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
>   { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
>   { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 
> },
> -- 
> 1.9.1
>

RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Biju Das 


> -Original Message-
> From: devicetree-ow...@vger.kernel.org [mailto:devicetree-
> ow...@vger.kernel.org] On Behalf Of Sergei Shtylyov
> Sent: 05 July 2017 14:21
> To: Biju Das <biju@bp.renesas.com>; Rob Herring <robh...@kernel.org>;
> Mark Rutland <mark.rutl...@arm.com>; Russell King
> <li...@armlinux.org.uk>
> Cc: Simon Horman <ho...@verge.net.au>; Magnus Damm
> <magnus.d...@gmail.com>; Chris Paterson
> <chris.paters...@renesas.com>; devicet...@vger.kernel.org; linux-renesas-
> s...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> Hello!
>
> On 07/05/2017 04:01 PM, Biju Das wrote:
>
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das <biju@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paters...@renesas.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv)  }
> >
> >  static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
>
> No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".
>

Thanks for the review. I will remove this change.

> >  { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
>
> MBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in the 
> body
> of a message to majord...@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Chris Paterson 
Hello Geert,

> From: geert.uytterhoe...@gmail.com
> [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 15:56
> 
> Hi Chris,
> 
> On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
>  wrote:
> >> From: geert.uytterhoe...@gmail.com
> >> [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert
> Uytterhoeven
> >> Sent: 05 July 2017 14:47
> >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das 
> wrote:
> >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the
> >> > R-Car
> >> > Gen2 family.
> >> >
> >> > Signed-off-by: Biju Das 
> >> > Reviewed-by: Chris Paterson 
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct
> >> > ravb_private
> >> > *priv)  }
> >> >
> >> >  static const struct of_device_id ravb_match_table[] = {
> >> > +   { .compatible = "renesas,etheravb-r8a7743", .data = (void
> >> > + *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> >> *)RCAR_GEN2 },
> >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> >> > *)RCAR_GEN2 },
> >>
> >> As Sergei already mentioned, a driver update is not needed due to the
> >> presence of family-specific compatible values.
> >> Please drop that part, and you can add my:
> >> Reviewed-by: Geert Uytterhoeven 
> >
> > Should the other compatible values (r8a7790, 94 etc) be removed then? Or
> are they needed for backwards compatibility?
> 
> The other compatible values in DT bindings and DTS files should be kept, to
> allow handling of SoC-specific quirks if/when they are ever detected.
> 
> The other compatible values in the driver should be kept for backwards-
> compatibility with old DTB files that lack the (newer) family-specific
> compatible values.

Thank you for the comprehensive answer.

Kind regards, Chris


> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Geert Uytterhoeven 
Hi Chris,

On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson
 wrote:
>> From: geert.uytterhoe...@gmail.com
>> [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert Uytterhoeven
>> Sent: 05 July 2017 14:47
>> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das  wrote:
>> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
>> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
>> > Gen2 family.
>> >
>> > Signed-off-by: Biju Das 
>> > Reviewed-by: Chris Paterson 
>>
>> Thanks for your patch!
>>
>> > --- a/drivers/net/ethernet/renesas/ravb_main.c
>> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
>> > *priv)  }
>> >
>> >  static const struct of_device_id ravb_match_table[] = {
>> > +   { .compatible = "renesas,etheravb-r8a7743", .data = (void
>> > + *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
>> *)RCAR_GEN2 },
>> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
>> > *)RCAR_GEN2 },
>>
>> As Sergei already mentioned, a driver update is not needed due to the
>> presence of family-specific compatible values.
>> Please drop that part, and you can add my:
>> Reviewed-by: Geert Uytterhoeven 
>
> Should the other compatible values (r8a7790, 94 etc) be removed then? Or are 
> they needed for backwards compatibility?

The other compatible values in DT bindings and DTS files should be kept,
to allow handling of SoC-specific quirks if/when they are ever detected.

The other compatible values in the driver should be kept for
backwards-compatibility with old DTB files that lack the (newer)
family-specific compatible values.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Chris Paterson 
Hello Geert, Sergei,

> From: geert.uytterhoe...@gmail.com
> [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert Uytterhoeven
> Sent: 05 July 2017 14:47
> 
> Hi Biju,
> 
> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das  wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
> >
> > Signed-off-by: Biju Das 
> > Reviewed-by: Chris Paterson 
> 
> Thanks for your patch!
> 
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv)  }
> >
> >  static const struct of_device_id ravb_match_table[] = {
> > +   { .compatible = "renesas,etheravb-r8a7743", .data = (void
> > + *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
> 
> As Sergei already mentioned, a driver update is not needed due to the
> presence of family-specific compatible values.
> Please drop that part, and you can add my:
> Reviewed-by: Geert Uytterhoeven 

Should the other compatible values (r8a7790, 94 etc) be removed then? Or are 
they needed for backwards compatibility?

Kind regards, Chris

> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Geert Uytterhoeven 
Hi Biju,

On Wed, Jul 5, 2017 at 3:01 PM, Biju Das  wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das 
> Reviewed-by: Chris Paterson 

Thanks for your patch!

> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
>  }
>
>  static const struct of_device_id ravb_match_table[] = {
> +   { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 
> },
> { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 
> },
> { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 
> },
> { .compatible = "renesas,etheravb-rcar-gen2", .data = (void 
> *)RCAR_GEN2 },

As Sergei already mentioned, a driver update is not needed due to the
presence of family-specific compatible values.
Please drop that part, and you can add my:
Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

2017-07-05 Thread Sergei Shtylyov 

Hello!

On 07/05/2017 04:01 PM, Biju Das wrote:


Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
family.

Signed-off-by: Biju Das 
Reviewed-by: Chris Paterson 

[...]

diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index 5931e85..e35b30f 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
 }

 static const struct of_device_id ravb_match_table[] = {
+   { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },


   No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".


{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 
},


MBR, Sergei