Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros
On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: > On 2015-12-07 17:33, David Laight wrote: > > From: Michal Marek > > > Sent: 04 December 2015 15:26 > > > Otherwise make tags can't parse them: > > > > > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern > > > "\1" > > ... > > > > Seems to me you need to fix ctags. > > I'm sure the maintainers of ctags and etags would accept patches to > describe a custom context-free grammar via commandline options, but > until then, let's continue using the regular expressions in tags.sh and > remove newlines in macros that tags.sh is trying to expand. > Do you have a list of the most common macros? Perhaps it'd be good to add exceptions to checkpatch 80 column line rules for them. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros
On 2015-12-07 17:33, David Laight wrote: > From: Michal Marek >> Sent: 04 December 2015 15:26 >> Otherwise make tags can't parse them: >> >> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern >> "\1" > ... > > Seems to me you need to fix ctags. I'm sure the maintainers of ctags and etags would accept patches to describe a custom context-free grammar via commandline options, but until then, let's continue using the regular expressions in tags.sh and remove newlines in macros that tags.sh is trying to expand. Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros
On 2015-12-07 18:04, Joe Perches wrote: > On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: >> On 2015-12-07 17:33, David Laight wrote: >>> From: Michal Marek Sent: 04 December 2015 15:26 Otherwise make tags can't parse them: ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" >>> ... >>> >>> Seems to me you need to fix ctags. >> >> I'm sure the maintainers of ctags and etags would accept patches to >> describe a custom context-free grammar via commandline options, but >> until then, let's continue using the regular expressions in tags.sh and >> remove newlines in macros that tags.sh is trying to expand. >> > > Do you have a list of the most common macros? In practice, it's only DEFINE_PER_CPU and its sibling DEFINE_PER_CPU_SHARED_ALIGNED, where we try to pick the second argument to the macro and the first argument can be lengthy. > Perhaps it'd be good to add exceptions to checkpatch > 80 column line rules for them. Your call. But this is a fairly rare occurrence -- 10 cases so far. Michal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros
From: Michal Marek > Sent: 04 December 2015 15:26 > Otherwise make tags can't parse them: > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" ... Seems to me you need to fix ctags. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
